gui: Avoid calling processEvents #16875

1. 
   promag commented at 2:01 pm on September 15, 2019: member

   Got the following stack trace while debugging #15204:

    0  * frame [#0](/bitcoin-bitcoin/0/): 0x00000001000e9ce6 bitcoin-qt`OpenExternalWalletActivity::finish(this=0x000000010e9023e0) at walletcontroller.cpp:303 [opt]
    1    frame [#1](/bitcoin-bitcoin/1/): 0x0000000101f6b34d QtCore`___lldb_unnamed_symbol2532$$QtCore + 173
    2    frame [#2](/bitcoin-bitcoin/2/): 0x0000000101f5b756 QtCore`QObject::event(QEvent*) + 102
    3    frame [#3](/bitcoin-bitcoin/3/): 0x000000010128746d QtWidgets`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
    4    frame [#4](/bitcoin-bitcoin/4/): 0x0000000101288897 QtWidgets`QApplication::notify(QObject*, QEvent*) + 583
    5    frame [#5](/bitcoin-bitcoin/5/): 0x0000000101f31f64 QtCore`QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
    6    frame [#6](/bitcoin-bitcoin/6/): 0x0000000101f89724 QtCore`QTimerInfoList::activateTimers() + 996
    7    frame [#7](/bitcoin-bitcoin/7/): 0x000000010343732f libqcocoa.dylib`___lldb_unnamed_symbol548$$libqcocoa.dylib + 2351
    8    frame [#8](/bitcoin-bitcoin/8/): 0x0000000101f32437 QtCore`QCoreApplication::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 39
    9    frame [#9](/bitcoin-bitcoin/9/): 0x00000001000b5aa3 bitcoin-qt`SendCoinsDialog::addEntry(this=0x00000001158a19a0) at sendcoinsdialog.cpp:443 [opt]
   10    frame [#10](/bitcoin-bitcoin/10/): 0x00000001000af369 bitcoin-qt`SendCoinsDialog::SendCoinsDialog(this=0x00000001158a19a0, _platformStyle=<unavailable>, parent=<unavailable>) at sendcoinsdialog.cpp:77 [opt]
   11    frame [#11](/bitcoin-bitcoin/11/): 0x00000001000f82c7 bitcoin-qt`WalletView::WalletView(this=0x000000011587e250, _platformStyle=<unavailable>, parent=<unavailable>) at walletview.cpp:58 [opt]
   12    frame [#12](/bitcoin-bitcoin/12/): 0x00000001000ec68c bitcoin-qt`WalletFrame::addWallet(this=0x000000010c01c460, walletModel=0x0000000111c81fd0) at walletframe.cpp:49 [opt]
   13    frame [#13](/bitcoin-bitcoin/13/): 0x000000010001f446 bitcoin-qt`BitcoinGUI::addWallet(this=0x000000010376ce90, walletModel=0x0000000111c81fd0) at bitcoingui.cpp:652 [opt]
   

   IMO we should avoid calling processEvents.

2. promag added the label Bug on Sep 15, 2019
3. fanquake added the label GUI on Sep 15, 2019
4. 
   fanquake commented at 9:58 am on August 14, 2020: member

   @promag if you think this is still worth having a standalone issue open for, can you re-open this in the GUI repo.
5. fanquake closed this on Aug 14, 2020

   ---

6. DrahtBot locked this on Feb 15, 2022

Contributors
promag fanquake

Labels
Bug GUI