gui: Drop calls to QCoreApplication::processEvents #16876

pull promag wants to merge 2 commits into bitcoin:master from promag:2019-09-drop-processevents changing 3 files +1 −3
  1. promag commented at 3:26 pm on September 15, 2019: member

    Addresses #16875. For now just remove the calls.

    These were introduced in #593 and #12818.

  2. gui: Drop calls to QCoreApplication::processEvents cef19450f0
  3. promag commented at 3:39 pm on September 15, 2019: member
    Some discussion in https://stackoverflow.com/a/1386160
  4. promag commented at 4:13 pm on September 15, 2019: member
    Could I have gitian build?
  5. DrahtBot added the label GUI on Sep 15, 2019
  6. fanquake added the label Needs gitian build on Sep 15, 2019
  7. fanquake commented at 0:32 am on September 16, 2019: member

    It looks like this has broken some GUI tests 585229862, 585229863, 585229866:

     0********* Start testing of WalletTests *********
 1Config: Using QtTest library 5.9.5, Qt 5.9.5 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0)
 2PASS   : WalletTests::initTestCase()
 3QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet
 4QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
 5QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 12537cd362d98a08b60e15109d9b328ba3c1b42a0b6abc443c3e8c6c58b23cd3 status= 0"
 6QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 864afb476316659fcf6e4717a4daa6d69c51b06b772ec8b3c6d86061856f133e status= 1"
 7QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: mfWxJ45yp2SFn7UciZyNpvDKrzbhyfKrY8  isMine=0 purpose=send status=0"
 8QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
 9QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 12537cd362d98a08b60e15109d9b328ba3c1b42a0b6abc443c3e8c6c58b23cd3 0"
10QDEBUG : WalletTests::walletTests() "    inModel=0 Index=86-86 showTransaction=1 derivedStatus=0"
11QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 864afb476316659fcf6e4717a4daa6d69c51b06b772ec8b3c6d86061856f133e 1"
12QDEBUG : WalletTests::walletTests() "    inModel=1 Index=27-28 showTransaction=1 derivedStatus=1"
13QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 52b3ca1ca8d757d595ea5501754c0b46762fc69fc1a668ea8fbda0d380a3d3bb status= 0"
14QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 154297156e2d1cd324cecb6cce2377c90fd6e59c87a12fbd84590809f44dc1f9 status= 1"
15FAIL!  : WalletTests::walletTests() Compared values are not the same
16   Actual   (transactionTableModel->rowCount({})): 106
17   Expected (107)                                : 107
18   Loc: [qt/test/wallettests.cpp(175)]
19PASS   : WalletTests::cleanupTestCase()
20Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 3780ms
21********* Finished testing of WalletTests *********
  8. DrahtBot commented at 6:22 pm on September 16, 2019: member

    Gitian builds for commit 9debfd0e28413df1ba669f614aa44bb652fedb32 (master):

    Gitian builds for commit 0957b55fc3117fa117c4479cdc0c27eaab1b29ea (master and this pull):

  9. DrahtBot removed the label Needs gitian build on Sep 16, 2019
  10. laanwj commented at 12:40 pm on September 18, 2019: member

    These calls are a work-around for doing too much work (and blocking waiting on locks) in the GUI thread, which we very much are guilty of in bitcoin-qt. The idea is to make sure that the window is updated and events are handled before doing something that might take longer.

    Calling the function is redundant, sometimes, but should never be a bug.

    Do you know why this segfaults in the first place? It seems to point at a different underlying issue and this just triggers it.

  11. promag commented at 7:43 am on September 19, 2019: member

    The idea is to make sure that the window is updated and events are handled before doing something that might take longer.

    Meh, I think we agree it’s the wrong fix. One reason is to rely on some event being processed which in turn initializes something needed.

    Do you know why this segfaults in the first place? It seems to point at a different underlying issue and this just triggers it.

    I don’t but will investigate.

  12. wip: Fix test a6133904e3
  13. Sjors commented at 6:06 pm on September 26, 2019: member
    #16966 has the side-effect of removing processEvents for bump fee
  14. DrahtBot commented at 9:44 pm on September 26, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  15. laanwj added the label Bug on Sep 30, 2019
  16. jonasschnelli commented at 7:32 am on May 29, 2020: contributor
    Closing for now. Feel free to reopen if this still makes sense.
  17. jonasschnelli closed this on May 29, 2020
  18. DrahtBot locked this on Feb 15, 2022


promag fanquake DrahtBot laanwj Sjors jonasschnelli

Labels
Bug GUI

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me