doc: Fix datadir path in 0.18.0 release notes #16893

pull ch4ot1c wants to merge 1 commits into bitcoin:master from ch4ot1c:doc/release-notes-0.18.0-fix changing 1 files +2 −2

ch4ot1c commented at 9:06 AM on September 17, 2019: contributor

No description provided.
fanquake added the label Docs on Sep 17, 2019

in doc/release-notes/release-notes-0.18.0.md:57 in f519569831 outdated

  53 | @@ -54,7 +54,7 @@ platform.
  54 |  If you are using the `systemd` unit configuration file located at
  55 |  `contrib/init/bitcoind.service`, it has been changed to use
  56 |  `/var/lib/bitcoind` as the data directory instead of
  57 | -`~bitcoin/.bitcoin`. When switching over to the new configuration file,
  58 | +`~/bitcoin/.bitcoin`. When switching over to the new configuration file,

theStack commented at 10:59 AM on September 17, 2019:

The default data directory is just ~/.bitcoin (see function GetDefaultDataDir(), https://github.com/bitcoin/bitcoin/blob/master/src/util/system.cpp#L686), so I think the first occurrence of bitcoin in the path has to be deleted.

doc: Fix datadir path in 0.18.0 release notes 0507cbc937
ch4ot1c force-pushed on Sep 17, 2019
MarcoFalke commented at 11:05 AM on September 17, 2019: member

unsigned ACK 0507cbc9376fc7c2effc29284d8a4df1f68f09dd
ryanofsky commented at 11:40 AM on September 17, 2019: member

~bitcoin refers to the home directory of the bitcoin user, so I think the documentation is correct as is, and this change just makes it more ambiguous. But if people are less familiar with multi-user systems than they used to be and ~bitcoin is confusing, maybe this change is an improvement. I just don't think it's a "fix"
MarcoFalke commented at 11:43 AM on September 17, 2019: member

Thanks for the input. Makes sense, so closing this for now.
MarcoFalke closed this on Sep 17, 2019
laanwj commented at 1:47 PM on September 17, 2019: member

I also think there's limited added value to updating historical release notes, save for serious things such as missing credits or dangerous suggestions. In which case you'd also want to update them on the bitcoincore.org site. But for something that very slighly improves readability I think it's not worth it.
ch4ot1c commented at 7:48 PM on September 17, 2019: contributor

Gotcha - this was the only place I found this usage (grep -nr "\~bitcoin" .), so it was just a smell. Learned something today!

Noted your advice on nitting release notes.
DrahtBot locked this on Dec 16, 2021

Contributors

Labels