AppVeyor CI: combine_logs.py fails to fetch debug logs #16894

1. 
   mzumsande commented at 10:19 am on September 17, 2019: member

   In case of failures of a functional test, the logs are not combined in the AppVeyor build, examples are https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/27454958 https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/26931920 This makes it harder to investigate the root cause of the failures of the functional tests. Some months ago it was still working (see linked logs in #14446).

   Error message from AppVeyor Log:

   0python test\functional\test_runner.py --ci --quiet --combinedlogslen=4000 --failfast
   1Traceback (most recent call last):
   2  File "C:\projects\bitcoin/test/functional/combine_logs.py", line 198, in <module>
   3    main()
   4  File "C:\projects\bitcoin/test/functional/combine_logs.py", line 65, in main
   5    log_events = read_logs(testdir)
   6  File "C:\projects\bitcoin/test/functional/combine_logs.py", line 84, in read_logs
   7    chain = re.search(r'node0/(.+?)/debug\.log$', chain).group(1)  # extract the chain name
   8AttributeError: 'NoneType' object has no attribute 'group'
   

2. mzumsande added the label Bug on Sep 17, 2019
3. fanquake added the label Tests on Sep 17, 2019
4. MarcoFalke added the label Windows on Sep 17, 2019
5. 
   MarcoFalke commented at 10:58 am on September 17, 2019: member

   The regex should use os.path.sep instead of hardcoding the linux one
6. MarcoFalke added the label good first issue on Sep 17, 2019
7. 
   renepickhardt commented at 11:36 am on September 17, 2019: none

   hopefully this should have fixed the issue. couldn’t test this though.
8. mzumsande referenced this in commit 04e12e2ea3 on Sep 17, 2019
9. MarcoFalke closed this on Oct 10, 2019

   ---

10. sidhujag referenced this in commit ef6d2956e9 on Oct 11, 2019
11. Munkybooty referenced this in commit f7624c6ca7 on Oct 7, 2021
12. Munkybooty referenced this in commit 7a3163e7a1 on Oct 14, 2021
13. Munkybooty referenced this in commit daf0ebcd5e on Oct 16, 2021
14. DrahtBot locked this on Dec 16, 2021
15. Munkybooty referenced this in commit b69cc33f99 on Feb 1, 2022
16. knst referenced this in commit 13e93f40b3 on Mar 24, 2023
17. knst referenced this in commit 90c1916090 on Apr 9, 2023
18. knst referenced this in commit f8c7cdae53 on Apr 17, 2023
19. knst referenced this in commit f3a1874a69 on Apr 19, 2023

Contributors
mzumsande MarcoFalke renepickhardt

Labels
Bug Windows Tests good first issue