Misleading description of useLegacyAddress checkbox #16924

1. 
   andronoob commented at 5:37 PM on September 20, 2019: none

   I see that legacy means P2PKH in both command line options and RPC help info:

   -addresstype
   What type of addresses to use ("legacy", "p2sh-segwit", or "bech32", default: "p2sh-segwit") 
   

   getnewaddress ( "label" "address_type" )
   ...
   2. address_type    (string, optional, default=set by -addresstype) The address type to use. Options are "legacy", "p2sh-segwit", and "bech32".
   ...
   

   The useLegacyAddress checkbox describes itself as “Generate legacy address” - however, it actually makes the wallet GUI generate “p2sh-segwit” address for the user if it's checked.

2. MarcoFalke added the label GUI on Sep 20, 2019
3. MarcoFalke added this to the milestone 0.19.0 on Sep 20, 2019
4. MarcoFalke added the label Brainstorming on Sep 20, 2019
5. 
   emilengler commented at 10:27 PM on September 20, 2019: contributor

   The p2sh segwit addresses are legacy. They exist since 2012(?) so you probably mean the 1 addresses. I see no point why this should be supported.

6. 
   sipa commented at 10:36 PM on September 20, 2019: member

   @emilengler "legacy" in the context of address types means p2pkh, nothing else.

   Your opinion on whether they should be supported is a distinct issue (about that: since p2sh-p2wpkh is more efficient than p2pkh, it should probably be preferred if we'd ever decide to stop distinguishing between the two).

7. laanwj closed this on Sep 25, 2019

   ---

8. sidhujag referenced this in commit a6ea861718 on Sep 25, 2019
9. DrahtBot locked this on Dec 16, 2021

Milestone
0.19.0