gui: Rename address checkbox back to bech32 #16928

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1909-guiBech32Wording changing 3 files +20 −20
  1. MarcoFalke commented at 12:27 pm on September 21, 2019: member

    This is the wording that has been used in the previous release, so translations should still exist for it.

    Fixes: #16924

  2. gui: Rename address checkbox back to bech32
    This is the wording that has been used in the previous release
    fa7847d99b
  3. MarcoFalke added the label Brainstorming on Sep 21, 2019
  4. MarcoFalke added the label GUI on Sep 21, 2019
  5. emilengler commented at 1:10 pm on September 21, 2019: contributor
    Concept ACK, as using legacy address is now opt in
  6. MarcoFalke commented at 1:15 pm on September 21, 2019: member
    This shouldn’t change the logic, only revert the wording to the previous state.
  7. emilengler commented at 1:36 pm on September 21, 2019: contributor
    That’s what I meant
  8. DrahtBot commented at 4:52 pm on September 21, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16884 (wallet: Change default address type to bech32 by instagibbs)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  9. promag commented at 9:32 am on September 22, 2019: member
    ACK fa7847d99b7084f1de5dc61506069e32de43a498.
  10. laanwj commented at 2:19 pm on September 25, 2019: member
    ACK fa7847d99b7084f1de5dc61506069e32de43a498
  11. laanwj referenced this in commit ae3902ee3f on Sep 25, 2019
  12. laanwj merged this on Sep 25, 2019
  13. laanwj closed this on Sep 25, 2019

  14. sidhujag referenced this in commit a6ea861718 on Sep 25, 2019
  15. MarcoFalke deleted the branch on Sep 25, 2019
  16. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-02 01:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me