build: only pass --disable-dependency-tracking to packages that understand it #16949

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:no_disable_dependency_tracking changing 13 files +15 −6
  1. fanquake commented at 3:18 AM on September 24, 2019: member

    By blanket passing --disable-dependency-tracking to all depends packages we end up with warnings (i.e in bdb or freetype) like:

    configure: WARNING: unrecognized options: --disable-dependency-tracking

    Instead, only pass it to packages that actually understand it. Related to #16354.

    More info on --disable-dependency-tracking available here.

    This PR also adds --enable-option-checking as a configure option to all applicable packages.

  2. fanquake added the label Build system on Sep 24, 2019
  3. fanquake added the label Needs gitian build on Sep 24, 2019
  4. fanquake requested review from dongcarl on Sep 24, 2019
  5. luke-jr commented at 3:28 AM on September 24, 2019: member

    Why is this a problem?

  6. DrahtBot commented at 4:23 AM on September 24, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17165 ([WIP] Remove BIP70 support by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. DrahtBot removed the label Needs gitian build on Sep 25, 2019
  8. laanwj commented at 7:49 PM on September 26, 2019: member

    Would be nice if there was a way to make it stop instead of warn on unknown configure arguments, This would make it easy to detect when say, a dependency upgrade invalidates some of the configuration.

  9. dongcarl commented at 3:44 PM on October 1, 2019: member

    I think we want to make sure that given the choice, we supply --disable-dependency-tracking, because the default is to enable it. In the case of an upgrade, I'm more worried about upstream packages enabling the --{dis,en}able-dependency-tracking toggle in a version bump, and us not setting it, than just a pesky warning.

  10. fanquake commented at 1:01 AM on October 2, 2019: member

    @dongcarl Would you rather a comment in funks.mk explaining the blanket passing rationale? I'd like to have it somewhat documented.

  11. dongcarl commented at 3:29 PM on October 2, 2019: member

    @dongcarl Would you rather a comment in funks.mk explaining the blanket passing rationale? I'd like to have it somewhat documented.

    Let's do that!

    <details> <summary><code>funks.mk</code></summary>

    giphy

    </details>

  12. theuni commented at 3:02 PM on October 11, 2019: member

    Concept ACK, looks good to me as-is.

    Would be nice if there was a way to make it stop instead of warn on unknown configure arguments, This would make it easy to detect when say, a dependency upgrade invalidates some of the configuration.

    Great idea, and there is! --disable-option-checking. +1 for wiring it up where applicable.

    Edit: Heh, we'd obviously want to flip this to --enable-option-checking for our use-case.

  13. build: only pass --disable-dependency-tracking to packages that understand it
    By blanket passing --disable-dependency-tracking to all depends packages
we end up with some warnings like:

configure: WARNING: unrecognized options: --disable-dependency-tracking

So instead, only pass it to packages that understand it.

Related to https://github.com/bitcoin/bitcoin/issues/16354.
    bcff8e21b1
  14. build: pass --enable-option-checking to applicable packages 1ba49bcdc2
  15. fanquake force-pushed on Oct 11, 2019
  16. fanquake added the label Needs gitian build on Oct 11, 2019
  17. fanquake commented at 5:42 PM on October 11, 2019: member

    Thanks @theuni. I've left the changes as they are, and added an additional commit that adds --enable-option-checking to the applicable packages. Also updated the PR description and queued up a new gitian build. I have tested a depends build locally on macOS and Debian 10 so far.

  18. DrahtBot commented at 3:49 AM on October 13, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit f4d93078dde502bb6a77dcc94ac6eafe20e36324 (master):

    Gitian builds for commit babbe24a220c72d5d505296795c178e92ab7cd3d (master and this pull):

  19. DrahtBot removed the label Needs gitian build on Oct 13, 2019
  20. laanwj commented at 8:52 AM on October 14, 2019: member

    ACK 1ba49bcdc216162f513e74e371ee9f26418a390e

  21. theuni approved
  22. theuni commented at 5:54 PM on October 18, 2019: member

    ACK 1ba49bcdc216162f513e74e371ee9f26418a390e

  23. MarcoFalke deleted a comment on Oct 18, 2019
  24. fanquake referenced this in commit fd3b4e422d on Oct 18, 2019
  25. fanquake merged this on Oct 18, 2019
  26. fanquake closed this on Oct 18, 2019
  27. fanquake deleted the branch on Oct 18, 2019
  28. sidhujag referenced this in commit 8fd9ef011a on Oct 21, 2019
  29. deadalnix referenced this in commit 3bf909b08e on Apr 3, 2020
  30. zkbot referenced this in commit e3d5ddbef4 on Oct 8, 2020
  31. zkbot referenced this in commit 6e4090d840 on Oct 8, 2020
  32. ftrader referenced this in commit d97fbb7d0e on Aug 13, 2021
  33. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakeluke-jrDrahtBotlaanwjdongcarltheuni


dongcarl

Labels
Build system
Linked (view graph)
#16354 build: Review of depends tree configure flags
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me