gui: crash trying to access info of a removed transaction #16950

1. 
   fanquake commented at 7:51 AM on September 24, 2019: member

   A call to removeprunedfunds does not update the transaction list in the GUI, and trying to access the info of a deleted transaction will result in a segfault.

   (lldb) run
   Process 4859 launched: '/Users/michael/github/bitcoin/src/qt/bitcoin-qt' (x86_64)
   2019-09-24 15:41:53.763094+0800 bitcoin-qt[4859:390268] MessageTracer: Falling back to default whitelist
   Process 4859 stopped
   * thread [#1](/bitcoin-bitcoin/1/), name = 'bitcoin-main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x34)
       frame [#0](/bitcoin-bitcoin/0/): 0x00000001001c9bf6 bitcoin-qt`TransactionDesc::FormatTxStatus(wtx=0x00007ffeefbfc0e0, status=0x00007ffeefbfc0c0, inMempool=false, numBlocks=1) at transactiondesc.cpp:33:31
      30  	{
      31  	    if (!status.is_final)
      32  	    {
   -> 33  	        if (wtx.tx->nLockTime < LOCKTIME_THRESHOLD)
      34  	            return tr("Open for %n more block(s)", "", wtx.tx->nLockTime - numBlocks);
      35  	        else
      36  	            return tr("Open until %1").arg(GUIUtil::dateTimeStr(wtx.tx->nLockTime));
   Target 0: (bitcoin-qt) stopped.
   

2. fanquake added the label GUI on Sep 24, 2019
3. jonasschnelli added this to the milestone 0.19.0 on Sep 24, 2019
4. laanwj added the label Bug on Sep 26, 2019
5. laanwj closed this on Oct 2, 2019

   ---

6. sidhujag referenced this in commit 1e10122858 on Oct 2, 2019
7. PastaPastaPasta referenced this in commit 83607a5f83 on Jun 27, 2021
8. PastaPastaPasta referenced this in commit 27422a8a37 on Jun 28, 2021
9. PastaPastaPasta referenced this in commit 7a9f66f583 on Jun 29, 2021
10. PastaPastaPasta referenced this in commit da0cb2c727 on Jul 1, 2021
11. PastaPastaPasta referenced this in commit ac4e42225f on Jul 1, 2021
12. PastaPastaPasta referenced this in commit 828adbc249 on Jul 12, 2021
13. PastaPastaPasta referenced this in commit fc0279ad80 on Jul 13, 2021
14. PastaPastaPasta referenced this in commit ecf642bb8a on Jul 13, 2021
15. MarcoFalke locked this on Dec 16, 2021

Milestone
0.19.0