validation: Make GetWitnessCommitmentIndex public #16956

1. 
   MarcoFalke commented at 3:20 pm on September 24, 2019: member

   GenerateCoinbaseCommitment is public and can be used in unit tests to update the witness commitment after the list of txs in a block has been changed. However, for it to work, the existing commitment (added by default in CreateNewBlock) must be removed (and thus its index must be known).

   Make that possible by exposing the GetWitnessCommitmentIndex helper function in the header.

2. validation: Make GetWitnessCommitmentIndex public fa607c2292
3. MarcoFalke added the label Refactoring on Sep 24, 2019
4. MarcoFalke added the label Validation on Sep 24, 2019
5. 
   jb55 commented at 3:47 pm on September 24, 2019: member

   ACK fa607c229295e0f0b89d5177b94d3381ab5e37d8
6. 
   jamesob commented at 4:10 pm on September 24, 2019: member

   ACK https://github.com/bitcoin/bitcoin/pull/16956/commits/fa607c229295e0f0b89d5177b94d3381ab5e37d8
7. 
   DrahtBot commented at 5:08 pm on September 24, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16411 (Signet support by kallewoof)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   promag commented at 8:14 am on September 25, 2019: member

   Why submit this as a separate PR? Just include this commit in the work you mention in #15845 (comment)?
9. 
   MarcoFalke commented at 12:39 pm on September 25, 2019: member

   Why submit this as a separate PR? Just include this commit in the work you mention in #15845 (comment)?

   A wallet change shouldn’t change validation code

10. 
    promag commented at 1:01 pm on September 25, 2019: member

    ACK fa607c229295e0f0b89d5177b94d3381ab5e37d8.
11. fanquake approved
12. 
    fanquake commented at 8:56 am on September 26, 2019: member

    ACK fa607c229295e0f0b89d5177b94d3381ab5e37d8 - This unblocks work in #15845.
13. fanquake referenced this in commit fdfaeb67de on Sep 26, 2019
14. fanquake merged this on Sep 26, 2019
15. fanquake closed this on Sep 26, 2019

    ---

16. MarcoFalke deleted the branch on Sep 26, 2019
17. sidhujag referenced this in commit 38fce4ad10 on Sep 26, 2019
18. 
    jnewbery commented at 4:48 pm on November 13, 2019: member

    It seems like #15845 isn’t going anywhere soon.

    I think the change in this PR should be reverted until it’s actually needed.

19. 
    MarcoFalke commented at 4:58 pm on November 13, 2019: member

    Eh? I use it in tests I wrote locally. I plan to submit them soon TM (c) 2020
20. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke jb55 jamesob DrahtBot promag fanquake jnewbery

Labels
Refactoring Validation