gui: Change sendcoins dialogue Yes to Send #16964

1. 
   instagibbs commented at 1:50 PM on September 25, 2019: member

   It's more self-explanatory, matches "cancel" better, and makes future extensions such as #16944 more directly understandable to the user.

2. Change sendcoins dialogue Yes to Send a649cc6a17
3. DrahtBot added the label GUI on Sep 25, 2019
4. 
   promag commented at 4:24 PM on September 25, 2019: member

   ACK

5. 
   DrahtBot commented at 6:11 PM on September 25, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16966 (ui: make send a wizard by Sjors)
   • #16944 (gui: create PSBT with watch-only wallet by Sjors)
   • #15987 (Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   emilengler commented at 6:57 PM on September 25, 2019: contributor

   Concept ACK

7. 
   Sjors commented at 8:29 AM on September 26, 2019: member

   Trivial code review ACK a649cc6. I also used Send in #16966 (ui - make send a wizard)

8. fanquake renamed this:
   GUI: Change sendcoins dialogue Yes to Send
   gui: Change sendcoins dialogue Yes to Send
   on Sep 26, 2019
9. 
   fanquake commented at 9:30 AM on September 26, 2019: member

   master (fdfaeb67de3694b436656f57ff65f1dc94b893f0):

   <img width="484" alt="master" src="https://user-images.githubusercontent.com/863730/65676904-44231c00-e083-11e9-9da4-d209e246467b.png">

   This PR (a649cc6a17b8d8d602c6b67037b0c926960f9cdb):

   <img width="479" alt="16964" src="https://user-images.githubusercontent.com/863730/65676941-51400b00-e083-11e9-9d60-9e5c547536b4.png">

10. 
    jonatack commented at 10:29 AM on September 26, 2019: member

    Code review ACK a649cc6a17b8d8d602c6b67037b0c926960f9cdb

    "Send" is more clear and removes any possible ambiguity.

11. 
    Sjors commented at 10:43 AM on September 26, 2019: member

    Note that bump fee uses the same dialog.

12. 
    laanwj commented at 11:08 AM on September 26, 2019: member

    Definitely better. ACK a649cc6a17b8d8d602c6b67037b0c926960f9cdb

    We don't have a translation for bare "Send" yet, so this has to go in after the 0.19 split.

13. fanquake added this to the milestone 0.20.0 on Sep 26, 2019
14. MarcoFalke referenced this in commit 19ba43ae2d on Oct 2, 2019
15. MarcoFalke merged this on Oct 2, 2019
16. MarcoFalke closed this on Oct 2, 2019

    ---

17. sidhujag referenced this in commit da4ce75ee1 on Oct 2, 2019
18. luke-jr referenced this in commit 77ae015497 on Nov 15, 2019
19. MarkLTZ referenced this in commit 6f7d4716f7 on Nov 17, 2019
20. jasonbcox referenced this in commit ad7f8efeca on Sep 1, 2020
21. PastaPastaPasta referenced this in commit a5a13e9f99 on Jun 27, 2021
22. PastaPastaPasta referenced this in commit c850fec079 on Jun 28, 2021
23. PastaPastaPasta referenced this in commit 83359cdac6 on Jun 29, 2021
24. PastaPastaPasta referenced this in commit 4aca3fa00b on Jul 1, 2021
25. PastaPastaPasta referenced this in commit 1c21116cc2 on Jul 1, 2021
26. PastaPastaPasta referenced this in commit 7ee36b407a on Jul 12, 2021
27. PastaPastaPasta referenced this in commit fb3f3747a4 on Jul 13, 2021
28. PastaPastaPasta referenced this in commit f46f16772d on Jul 13, 2021
29. DrahtBot locked this on Dec 16, 2021

Contributors

instagibbspromagDrahtBotemilenglerSjorsfanquakejonatacklaanwj

Milestone
0.20.0