qt: Change default size of intro frame #16971

pull emilengler wants to merge 1 commits into bitcoin:master from emilengler:2019-09-qt-change-intro-default-size changing 1 files +1 −0
  1. emilengler commented at 6:26 pm on September 26, 2019: contributor

    Because of the new pruning feature in the intro frame, the size of the intro frame is too small. Like you see, some text is not visible completely.

    Before

    Before

    After

    After

    Update: I changed it so it adjusts the size dynamically

  2. hebasto commented at 6:28 pm on September 26, 2019: member

    Like you see, some text is not visible completely.

    What OS? HDPI?

  3. emilengler commented at 6:29 pm on September 26, 2019: contributor
    @hebasto Debian 10 with MATE. 1920x1080
  4. MarcoFalke added the label Needs gitian build on Sep 26, 2019
  5. laanwj commented at 7:06 pm on September 26, 2019: member
    it’s a bit shitty that a fixed size in pixels has to be hardcoded, as how much is needed depends on DPI and font size
  6. emilengler commented at 7:16 pm on September 26, 2019: contributor
    @laanwj I’m not sure if this feature is available in Qt but I remember that Windows Forms had a feature where the gui size was dynamically adjusted by the elements in the frame. However I’m not 100% sure.
  7. promag commented at 7:30 pm on September 26, 2019: member
    I’ll test.
  8. qt: Change default size of intro frame 8cf9898b53
  9. emilengler commented at 7:52 pm on September 26, 2019: contributor
    @laanwj @hebasto Nevermind, I found a way to do it dynamically
  10. MarcoFalke removed the label Needs gitian build on Sep 26, 2019
  11. promag commented at 8:25 pm on September 26, 2019: member
    I’m still playing around but I don’t think adjustSize() is the right fix here, you can still resize the window and mess with the visible text.
  12. fanquake added the label GUI on Sep 26, 2019
  13. fanquake commented at 7:05 am on September 27, 2019: member

    ACK 8cf9898b53d74bd474cc5188e07e671e24a3791f - Before and after macOS screens below. Given that most users will only ever see this screen once, I think Qts best effort to dynamically size it is fine.

    you can still resize the window and mess with the visible text.

    Users are free to resize and manipulate windows as they see fit. I think as long as we present a best effort, well-sized initial view, that should be fine.

    master (6288f15f50ab98b336ab86804c4cbea3807dc1d3):

    master

    this PR (8cf9898b53d74bd474cc5188e07e671e24a3791f):

    pr

  14. MarcoFalke added the label Needs gitian build on Sep 27, 2019
  15. emilengler commented at 1:52 pm on September 27, 2019: contributor
    @promag It is only adjusted once, at the beginning. Like fanquake said users should be free to change the size of the window to whatever they want.
  16. promag commented at 2:50 pm on September 27, 2019: member

    @fanquake @emilengler I’m just saying that this shouldn’t be possible: Screenshot 2019-09-27 at 15 48 49

    Size policies should be set in a way to prevent this.

  17. emilengler commented at 2:59 pm on September 27, 2019: contributor
    @promag This is also possible with the current one. The PR is not to make the intro frame dynamically, it is qt: Change default size of intro frame
  18. MarcoFalke added this to the milestone 0.19.0 on Sep 27, 2019
  19. DrahtBot commented at 3:56 am on September 28, 2019: member

    Gitian builds for commit 6288f15f50ab98b336ab86804c4cbea3807dc1d3 (master):

    Gitian builds for commit 10af78bc6aafb2796d069cd35c1f18a845de76cb (master and this pull):

  20. DrahtBot removed the label Needs gitian build on Sep 28, 2019
  21. jonasschnelli commented at 0:52 am on September 30, 2019: contributor

    Nice!

    utACK 8cf9898b53d74bd474cc5188e07e671e24a3791f

  22. Sjors commented at 8:58 am on September 30, 2019: member

    Tested ACK 8cf9898 on macOS. English already fit, so to reproduce the issue, launch in German with -resetguisettings -lang=de.

    A solution that uses layout constraints in the UI file would be nicer, but this does the job for 0.19 release.

  23. promag commented at 9:01 am on September 30, 2019: member

    A solution that uses layout constraints in the UI file would be nicer, but this does the job for 0.19 release.

    Agree.

  24. laanwj commented at 9:25 am on September 30, 2019: member
    Nice solution! ACK 8cf9898b53d74bd474cc5188e07e671e24a3791f
  25. laanwj referenced this in commit d6026ec874 on Sep 30, 2019
  26. laanwj merged this on Sep 30, 2019
  27. laanwj closed this on Sep 30, 2019
  28. emilengler deleted the branch on Sep 30, 2019
  29. MarcoFalke commented at 5:55 pm on September 30, 2019: member
    ACK 8cf9898b53d74bd474cc5188e07e671e24a3791f
  30. sidhujag referenced this in commit 4122df92e8 on Oct 2, 2019
  31. jasonbcox referenced this in commit af0d6d4863 on Oct 23, 2020
  32. PastaPastaPasta referenced this in commit b0556b9af2 on Jun 27, 2021
  33. PastaPastaPasta referenced this in commit f9a4f3b967 on Jun 28, 2021
  34. PastaPastaPasta referenced this in commit cb6375d60a on Jun 29, 2021
  35. PastaPastaPasta referenced this in commit 2f45ea112c on Jul 1, 2021
  36. PastaPastaPasta referenced this in commit 4c07dcaf7a on Jul 1, 2021
  37. PastaPastaPasta referenced this in commit a2cf722e4d on Jul 12, 2021
  38. PastaPastaPasta referenced this in commit 0eb08e034d on Jul 13, 2021
  39. PastaPastaPasta referenced this in commit d181c0126e on Jul 13, 2021
  40. DrahtBot locked this on Dec 16, 2021


emilengler hebasto laanwj promag fanquake DrahtBot jonasschnelli Sjors MarcoFalke

Labels
GUI

Milestone
0.19.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me