doc: Consolidate release notes before 0.19.0 (move-only) #17014

1. 
   MarcoFalke commented at 6:58 PM on October 1, 2019: member

   No description provided.

2. doc: Add missing release notes for 16383 fa02f2d607
3. doc: Consolidate release notes before 0.19.0

   Can be reviewed with the git diff options:
   
   --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

   fa3d98426b
4. MarcoFalke added this to the milestone 0.19.0 on Oct 1, 2019
5. 
   MarcoFalke commented at 6:59 PM on October 1, 2019: member

   Also, add missing notes for #16383, follow up to #16690 (review)

6. DrahtBot added the label Docs on Oct 1, 2019
7. in doc/release-notes.md:194 in fa3d98426b

    189 |  - `getdescriptorinfo` now returns an additional `checksum` field
    190 |    containing the checksum for the unmodified descriptor provided by the
    191 |    user (that is, before the descriptor is normalized for the
    192 |    `descriptor` field). (#15986)
    193 |  
    194 | +- `joinpsbts` will shuffle the order of the inputs and outputs of the resulting joined psbt.
   

   ---

   ---

   

   jonatack commented at 8:21 PM on October 1, 2019:

   Nit: use present tense here like the other notes do, e.g. s/will shuffle/now shuffles/

   ---

   

   MarcoFalke commented at 9:06 PM on October 1, 2019:

   I'd prefer to keep this move-only. It can be changed in the wiki by anyone, once they are moved: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.19.0-Release-Notes-Draft

   ---

   

   jonatack commented at 2:53 PM on October 2, 2019:

   Done in the wiki.

8. in doc/release-notes.md:195 in fa3d98426b

    190 |    containing the checksum for the unmodified descriptor provided by the
    191 |    user (that is, before the descriptor is normalized for the
    192 |    `descriptor` field). (#15986)
    193 |  
    194 | +- `joinpsbts` will shuffle the order of the inputs and outputs of the resulting joined psbt.
    195 | +  Previously inputs and outputs were added in the order that the PSBTs were provided which makes correlating inputs to outputs extremely easy.
   

   ---

   ---

   

   jonatack commented at 8:24 PM on October 1, 2019:

   Suggestion: "Previously, inputs and outputs were added in the order PSBTs were provided. This made it easy to correlate inputs to outputs, representing a privacy leak."

   ---

   

   MarcoFalke commented at 9:06 PM on October 1, 2019:

   I'd prefer to keep this move-only. It can be changed in the wiki by anyone, once they are moved: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.19.0-Release-Notes-Draft

   ---

   

   jonatack commented at 2:53 PM on October 2, 2019:

   Done in the wiki.

9. 
   jonatack commented at 8:26 PM on October 1, 2019: member

   A couple of suggestions below.

10. MarcoFalke renamed this:
    doc: Consolidate release notes before 0.19.0
    doc: Consolidate release notes before 0.19.0 (move-only)
    on Oct 1, 2019
11. fanquake approved
12. 
    fanquake commented at 12:41 AM on October 2, 2019: member

    ACK fa3d98426b35c0ece2853ce9fe46acd46f678ba3 - these can get massaged / nitted to death in the wiki.

13. fanquake referenced this in commit 1f40a91286 on Oct 2, 2019
14. fanquake merged this on Oct 2, 2019
15. fanquake closed this on Oct 2, 2019

    ---

16. 
    laanwj commented at 8:57 AM on October 2, 2019: member

    Posthumous ACK.

17. 
    jonatack commented at 9:45 AM on October 2, 2019: member

    Right, future release notes draft at:

    https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.19.0-Release-Notes-Draft

18. MarcoFalke deleted the branch on Oct 2, 2019
19. DrahtBot locked this on Dec 16, 2021

Contributors

MarcoFalkejonatackfanquakelaanwj

Milestone
0.19.0