Simplify statement. #17064

pull jbampton wants to merge 1 commits into bitcoin:master from jbampton:20191006-simplify-statement changing 1 files +1 −1
  1. jbampton commented at 1:44 AM on October 6, 2019: contributor

    Simplify call to CastToBool in if statement.

    Standardizes the statement to the same way it's called previously.

  2. Simplify statement. a9e769ecb0
  3. fanquake commented at 1:50 AM on October 6, 2019: member

    Thanks, however see the section in CONTRIBUTING.MD on refactoring.

  4. fanquake closed this on Oct 6, 2019

  5. MarcoFalke commented at 9:45 AM on October 6, 2019: member

    Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

    • Time spent on review
    • Accidental introduction of bugs
    • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

    For more information about refactoring changes and stylistic cleanup, see

    Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

    Let me know if you have any questions.

  6. MarcoFalke commented at 9:45 AM on October 6, 2019: member

    If you are looking for useful contributions to help out with, you can

    • Search through the good first issues or the ones that are up for grabs. Some of them might no longer be applicable. So if you are interested, but unsure, you might want to leave a comment on the issue first.
    • Write tests to improve the coverage. Both unit tests and functional tests are welcome. Coverage information can be obtained from a relatively recent coverage report.
    • Help with review and testing. There are easy ones such as the gui and rpc. However, review on any open pull request is welcome. Review will also help you understand the codebase better.
    • Help on meta projects related to Bitcoin Core, such as a high-level performance monitor.
    • Join us on irc and let us know what you are interested in.
  7. jbampton deleted the branch on Oct 14, 2019
  8. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me