qt: Always generate `bitcoinstrings.cpp` on `make translate` #17068

pull D4nte wants to merge 1 commits into bitcoin:master from D4nte:16891-gettext-mac changing 1 files +2 −2

D4nte commented at 4:40 AM on October 7, 2019: none

Resolves #16891.

bitcoinstrings.cpp is to be generated at release time. Hence, it should not depend on whether the source files are younger as the releaser may proceed from a fresh checkout.

More information on the investigation in the issue.

Always generate `bitcoinstrings.cpp` on `make translate`

`bitcoinstrings.cpp` is to be generated at release time. Hence,
it should not depend on whether the source files are younger as the
releaser may proceed from a fresh checkout.

c640ca24f9

D4nte renamed this:
~~Always generate `bitcoinstrings.cpp` on `make translate`~~
qt: Always generate `bitcoinstrings.cpp` on `make translate`
on Oct 7, 2019
DrahtBot added the label Build system on Oct 7, 2019
DrahtBot added the label GUI on Oct 7, 2019
laanwj commented at 8:47 AM on October 8, 2019: member

Concept ACK. Can you please test it on a Mac @fanquake ?

FORCE is generally a kludge, but for a sub-command that is explicitly called like make translate (whose result is meant to be checked in). I think it's fine.
jonasschnelli commented at 9:22 AM on October 8, 2019: contributor

Tested master on macOS 10.14 and ran into the same issue #16891 (when changing bitcoinstrings.cpp).

Tested ACK c640ca24f9d94f468ec6de023bf885813ac6c9a9 - Tested master + this on macOS 10.14. With this PR, it always "runs" GEN qt/bitcoinstrings.cpp and GEN translate.
laanwj referenced this in commit e173d587e1 on Oct 8, 2019
laanwj merged this on Oct 8, 2019
laanwj closed this on Oct 8, 2019
sidhujag referenced this in commit d5dfe39b08 on Oct 8, 2019
D4nte deleted the branch on Oct 9, 2019
MarkLTZ referenced this in commit 78c71c6a08 on Nov 17, 2019
deadalnix referenced this in commit a39dd32352 on Apr 21, 2020
UdjinM6 referenced this in commit 689da59e3d on Mar 22, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#16891 build: make translate not working correctly on macOS