Android depends #17078

pull BlockMechanic wants to merge 4 commits into bitcoin:master from BlockMechanic:android-depends changing 13 files +183 −3

BlockMechanic commented at 6:04 pm on October 8, 2019: contributor

Includes necessary changes to the depends and patches to enable android Qt builds. based on previous work here :- #16916 rebased to master.
Create android.mk
Added android file
4a35012c8c
Package mods for android build ebc55584d4
QT fixes for android depends and libevent patch c348394dca
Add android qmake fixes d3aa2fe784
fanquake added the label Android on Oct 8, 2019
fanquake added the label Build system on Oct 8, 2019
fanquake commented at 6:13 pm on October 8, 2019: member

@BlockMechanic can you address my comments from the previous PR. Mainly basing this off the work that is already being done in #16110, rather than duplicating the changes.
BlockMechanic commented at 6:17 pm on October 8, 2019: contributor

These depends deal specifically with building QT for android as is. For the necessary changes to build the QML version, i’ll push those later
BlockMechanic commented at 6:21 pm on October 8, 2019: contributor

@fanquake sorry, i am still getting used to using git and performing advanced actions like fethcing someone else’s branch , and pushing changes here…hence the mess up i mentioned. I managed to get @icota’s branch for #16110 but could not get it to cooperate properly on my end so i could push here.
DrahtBot commented at 11:06 pm on October 8, 2019: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17165 (Remove BIP70 support by fanquake)
- #17008 (build: bump libevent to 2.1.11 in depends by stefanwouldgo)
- #16110 (depends: Add Android NDK support by icota)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj commented at 8:59 am on October 9, 2019: member

Mainly basing this off the work that is already being done in #16110, rather than duplicating the changes.

Good point. I think it would be good if the people working on bitcoin core on Android (@greenaddress, @BlockMechanic, @icota), would start working together instead of besides each other. It’s not clear to me how the different changes relate to each other. Maybe we need an Android maintainer at some point. This worked for Windows/MSVC pretty well.
icota commented at 9:44 am on October 9, 2019: contributor

@laanwj I think the difference is that @BlockMechanic is trying to support 32-bit ARM and x86 as well. Like I commented in #16916 I don’t personally see much value and don’t have the devices to test this. But changes on top of #16110 are very welcome.

I’m working on a “packaging” PR (to produce an APK) to complement this. It is all very conceptual at this stage but if everything goes to plan and the PRs come together nicely (UI + reproducible build/package) I’d like to volunteer as the Android maintainer. But let’s give it some time.
fanquake added the label Needs Conceptual Review on Oct 9, 2019
fanquake commented at 3:28 pm on October 9, 2019: member

Yes my point is mainly that, for example, both PRs are bringing in a arc4random_addrandom patch for libevent, so it’d make sense for this PR be based #16110 (opened first, I prefer the patch naming there as well), rather than them being worked on in parallel.
DrahtBot added the label Needs rebase on Oct 26, 2019
DrahtBot commented at 11:12 am on October 26, 2019: member
BlockMechanic commented at 11:44 am on October 26, 2019: contributor

This is now completed in #16110
BlockMechanic closed this on Oct 26, 2019
fanquake removed the label Needs Conceptual Review on Aug 20, 2020
fanquake removed the label Needs rebase on Aug 20, 2020
DrahtBot locked this on Feb 15, 2022

Contributors
BlockMechanic fanquake DrahtBot laanwj icota

Labels
Build system Android

Android depends #17078

Conflicts