tests: Fix fs_tests for unknown locales #17086

1. 
   carnhofdaki commented at 2:51 PM on October 9, 2019: contributor

   Fix by removing "L" as suggested by meeDamian in #14948 (comment)

   # all in .../bitcoin/src/test
   $ uname -m
   x86_64
   $ export LC_ALL=randomnonexistentlocale
   $ ./test_bitcoin
   Running 369 test cases...
   unknown location(0): fatal error: in "fs_tests/fsbridge_fstream": boost::system::system_error: boost::filesystem::path codecvt to string: error
   test/fs_tests.cpp(13): last checkpoint: "fsbridge_fstream" test entry
   
   *** 1 failure is detected in the test module "Bitcoin Core Test Suite"
   

   After the patch is applied, the same test under the same conditions runs fine.

   $ export LC_ALL=randomnonexistentlocale
   $ ./test_bitcoin
   Running 369 test cases...
   
   *** No errors detected
   

   Co-Authored-By: bugs@meedamian.com

2. fanquake added the label Tests on Oct 9, 2019
3. carnhofdaki force-pushed on Oct 9, 2019
4. 
   fanquake commented at 3:02 PM on October 9, 2019: member

   @carnhofdaki please remove any @mentions from your commit message. I have removed the one in your PR description. We don't include them in either as they just result in spam. If you'd like to attribute the change you could use the Co-Authored-By: name <email> syntax in your commit.

5. 
   laanwj commented at 3:13 PM on October 9, 2019: member

   ACK (after fanquake's comment addressed)

   Comment #14948 (comment) Turns out this is the only place a L" string is used (besides a windows-specific workaround in src/util/system.cpp, irrelevant to this). No need to test this if we're not using it in the application.

6. fanquake added the label Waiting for author on Oct 9, 2019
7. carnhofdaki force-pushed on Oct 10, 2019
8. 
   carnhofdaki commented at 7:15 AM on October 10, 2019: contributor

   @fanquake thank you for comment. Done. Is it good now?

9. 
   meeDamian commented at 9:01 PM on October 12, 2019: contributor

   please remove any @mentions from your commit message. I have removed the one in your PR description. We don't include them in either as they just result in spam.

   💔, but 💯 agree.

   This change fixes builds for me, looking forward to merge!

10. laanwj renamed this:
    tests: Fix fs_tests for unknows locales
    tests: Fix fs_tests for unknown locales
    on Oct 14, 2019
11. carnhofdaki force-pushed on Oct 15, 2019
12. tests: Fix fs_tests for unknown locales

    Fix by removing "L" as suggested by meeDamian in
    https://github.com/bitcoin/bitcoin/issues/14948#issuecomment-522355441
    
    Co-Authored-By: bugs@meedamian.com

    d48f664440
13. carnhofdaki force-pushed on Oct 15, 2019
14. 
    laanwj commented at 9:33 AM on October 15, 2019: member

    ACK d48f664440e7bb3ff7a90b6d706a3ac2cfaec95a

    Hrmph, we should probably fix the false-positive in github-merge.py for full mail addresses. Those don't get notified (afaik).

15. laanwj referenced this in commit b544eb6370 on Oct 15, 2019
16. laanwj merged this on Oct 15, 2019
17. laanwj closed this on Oct 15, 2019

    ---

18. carnhofdaki deleted the branch on Oct 15, 2019
19. 
    hebasto commented at 4:28 PM on October 15, 2019: member

    Post-merge ACK. Tested on ODROID-HC1:

    $ gcc --version
    gcc (Ubuntu/Linaro 7.4.0-1ubuntu1~18.04.1) 7.4.0
    Copyright (C) 2017 Free Software Foundation, Inc.
    This is free software; see the source for copying conditions.  There is NO
    warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
    
    $ locale
    LANG=
    LANGUAGE=
    LC_CTYPE="POSIX"
    LC_NUMERIC="POSIX"
    LC_TIME="POSIX"
    LC_COLLATE="POSIX"
    LC_MONETARY="POSIX"
    LC_MESSAGES="POSIX"
    LC_PAPER="POSIX"
    LC_NAME="POSIX"
    LC_ADDRESS="POSIX"
    LC_TELEPHONE="POSIX"
    LC_MEASUREMENT="POSIX"
    LC_IDENTIFICATION="POSIX"
    LC_ALL=
    

    Could this PR be backported to 0.19?

20. MarcoFalke removed the label Waiting for author on Oct 15, 2019
21. MarcoFalke added the label Needs backport (0.19) on Oct 15, 2019
22. MarcoFalke added this to the milestone 0.19.0 on Oct 15, 2019
23. 
    carnhofdaki commented at 7:55 AM on October 16, 2019: contributor

    @hebasto sure! See #17158 @MarcoFalke What is the process for backports? (In case I did something wrong)

24. carnhofdaki referenced this in commit bd9d40dbbd on Oct 16, 2019
25. laanwj referenced this in commit 3834d3d121 on Oct 16, 2019
26. fanquake removed the label Needs backport (0.19) on Oct 19, 2019
27. 
    fanquake commented at 5:52 PM on October 19, 2019: member

    Backported in #17158.

28. HashUnlimited referenced this in commit 4f27058988 on Nov 17, 2019
29. fxtc referenced this in commit b816389b73 on Nov 25, 2019
30. fxtc referenced this in commit 4f9cec8076 on Nov 25, 2019
31. 
    Sjors commented at 1:31 PM on November 27, 2019: member

    This fixed the test suite for me on an armv7 device.

32. deadalnix referenced this in commit 7da0e8e564 on Apr 10, 2020
33. UdjinM6 referenced this in commit 144bf39039 on Jun 22, 2021
34. kittywhiskers referenced this in commit 6a11e06372 on Jun 24, 2021
35. PastaPastaPasta referenced this in commit e8875967b5 on Jun 25, 2021
36. MarcoFalke locked this on Dec 16, 2021

Contributors

carnhofdakifanquakelaanwjmeeDamianhebastoSjors

Milestone
0.19.0