build: Add variable printing target to Makefiles #17087

dongcarl commented at 3:15 PM on October 9, 2019: member

I kept finding myself needing these to debug our build system, since
they are innocuous and are very helpful they probably belong in the
codebase.

Source: John Graham-Cumming
https://www.cmcrossroads.com/article/printing-value-makefile-variable

build: Add variable printing target to Makefiles

I kept finding myself needing these to debug our build system, since
they are innocuous and are very helpful they probably belong in the
codebase.

Source: John Graham-Cumming
https://www.cmcrossroads.com/article/printing-value-makefile-variable

181989f6c9

dongcarl added the label Build system on Oct 9, 2019

hebasto commented at 4:32 PM on October 9, 2019: member

The whole OP seems like a block of code ;)

dongcarl commented at 4:38 PM on October 9, 2019: member

The whole OP seems like a block of code ;)

How else would I get people to recognize that I follow line length limits in my commit messages! :grin:

MarcoFalke commented at 4:43 PM on October 9, 2019: member

I read those as a quote and it takes me a minute to figure out who is meant with I

MarcoFalke commented at 6:08 PM on October 9, 2019: member

ACK 181989f6c9427fc266dbdcc84cb60ac03e67cdb2

$ git checkout 181989f6c9427fc266dbdcc84cb60ac03e67cdb2~1 && make print-top_srcdir
HEAD is now at 1c11e53bb6 Merge [#17041](/bitcoin-bitcoin/17041/): ci: Run tests on arm
make: *** No rule to make target 'print-top_srcdir'.  Stop.

$ git checkout 181989f6c9427fc266dbdcc84cb60ac03e67cdb2~0 && make print-top_srcdir
Previous HEAD position was 1c11e53bb6 Merge [#17041](/bitcoin-bitcoin/17041/): ci: Run tests on arm
HEAD is now at 181989f6c9 build: Add variable printing target to Makefiles
 cd . && /bin/sh /home/marco/workspace/btc_bitcoin_core/build-aux/missing automake-1.16 --foreign Makefile
 cd . && /bin/sh ./config.status Makefile 
config.status: creating Makefile
top_srcdir = .

<details><summary>Show signature and timestamp</summary>

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 181989f6c9427fc266dbdcc84cb60ac03e67cdb2

$ git checkout 181989f6c9427fc266dbdcc84cb60ac03e67cdb2~1 && make print-top_srcdir HEAD is now at 1c11e53bb6 Merge #17041: ci: Run tests on arm make: *** No rule to make target 'print-top_srcdir'. Stop.

$ git checkout 181989f6c9427fc266dbdcc84cb60ac03e67cdb2~0 && make print-top_srcdir Previous HEAD position was 1c11e53bb6 Merge #17041: ci: Run tests on arm HEAD is now at 181989f6c9 build: Add variable printing target to Makefiles cd . && /bin/sh /home/marco/workspace/btc_bitcoin_core/build-aux/missing automake-1.16 --foreign Makefile cd . && /bin/sh ./config.status Makefile config.status: creating Makefile top_srcdir = .

Timestamp of file with hash ceb9bcc607d08509cccb7193e0e0e4f3df49f218ec4d143d4f5fd1bc4b08f8a1 -

</details>

promag commented at 8:41 PM on October 9, 2019: member

ACK, nice one!

fanquake approved

fanquake commented at 9:43 PM on October 9, 2019: member

ACK 181989f6c9427fc266dbdcc84cb60ac03e67cdb2 - concise amount of useful code. Tested on macOS. Did not visit the link.

$ make print-BITCOIND_BIN
BITCOIND_BIN = ./src/bitcoind
$ make -C depends/ print-SOURCES_PATH
SOURCES_PATH = /Users/michael/github/bitcoin/depends/sources

fanquake referenced this in commit bc7e721d97 on Oct 9, 2019

fanquake merged this on Oct 9, 2019

fanquake closed this on Oct 9, 2019

deadalnix referenced this in commit 03a481b380 on Apr 3, 2020

MarkLTZ referenced this in commit 3b69b903d9 on Apr 6, 2020

ftrader referenced this in commit feabdecacd on Aug 17, 2020

zkbot referenced this in commit a0158ce837 on Jan 15, 2021

MarcoFalke locked this on Jan 16, 2021

fanquake deleted a comment on Jan 16, 2021