appveyor: Add -l test_suite to .appveyor.yaml #17110

pull ernestognw wants to merge 1 commits into bitcoin:master from ernestognw:master changing 1 files +1 −1

ernestognw commented at 7:15 PM on October 11, 2019: none

As requested on #16976

No breaking changes
fix(appveyor): Add -l test_suite to .appveyor.yaml.
As requested on #16976 No breaking changes
f62e79a354
MarcoFalke renamed this:
~~fix(appveyor): Add -l test_suite to .appveyor.yaml.~~
appveyor: Add -l test_suite to .appveyor.yaml
on Oct 11, 2019
MarcoFalke added the label Tests on Oct 11, 2019
in .appveyor.yml:63 in f62e79a354
```
  59 | @@ -60,7 +60,7 @@ after_build:
  60 |  - ps:  clcache -z
  61 |  #- 7z a bitcoin-%APPVEYOR_BUILD_VERSION%.zip %APPVEYOR_BUILD_FOLDER%\build_msvc\%platform%\%configuration%\*.exe
  62 |  test_script:
  63 | -- cmd: src\test_bitcoin.exe -k stdout -e stdout 2> NUL
  64 | +- cmd: src\test_bitcoin.exe -l test_suite -k stdout -e stdout 2> NUL
```
MarcoFalke commented at 1:55 PM on October 16, 2019:

that is going to print the boost test messages always, even if everything passes

I am not sure about any log limits for appveyor, but this seems a bit verbose to me

MarcoFalke commented at 1:56 PM on October 16, 2019:

Also, it would be nice to run the tests in parallel (like we do with automake make check -j xx)

MarcoFalke commented at 12:04 AM on December 17, 2019:

Jup, it does print it unconditionally: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/29582061#L1000
fanquake added the label Waiting for author on Nov 2, 2019
MarcoFalke commented at 1:55 PM on December 4, 2019: member

re-run ci
MarcoFalke closed this on Dec 4, 2019
MarcoFalke reopened this on Dec 4, 2019

MarcoFalke commented at 3:32 PM on December 4, 2019: member

Doesn't work (nothing is printed):

src\test_bitcoin.exe -l test_suite -k stdout -e stdout 2> NUL
Command exited with code -1073741819

MarcoFalke commented at 3:32 PM on December 4, 2019: member

cc @sipsorcery
sipsorcery commented at 4:59 PM on December 4, 2019: member

Looks like #17573 may be causing test_bitcoin.exe to seemingly do nothing. Currently tracking down why.
sipsorcery commented at 6:11 AM on December 5, 2019: member

Running the test_bitcoin.exe with the addition of -l test_suite adds just under 1000 lines of logs to the appveyor output. I suspect it has a negligible impact on the appveyor job performance.

My concern would be for contributors needing to look at the logs the burden is increased. I don't think it gives us a lot of bang for our buck as most of the failures are at the build stage or the python functional tests. If a way could be found to only output the logs if there's a test_bitcoin.exe failure that would be useful.
MarcoFalke added the label Up for grabs on Dec 5, 2019
MarcoFalke commented at 10:14 PM on December 16, 2019: member

re-run ci
MarcoFalke closed this on Dec 16, 2019
MarcoFalke reopened this on Dec 16, 2019
fanquake commented at 8:29 AM on January 5, 2020: member

Going to close. @sipsorcery maybe you'd like to pick this up if you think it's an improvement.
fanquake closed this on Jan 5, 2020
fanquake removed the label Waiting for author on May 28, 2020
DrahtBot locked this on Feb 15, 2022
MarcoFalke removed the label Up for grabs on Mar 22, 2022

Contributors

Labels

Linked (view graph)

#16976 appveyor should print boost test_suite log on failure