test: speed up wallet_address_types by whitelisting peers (immediate tx relay) #17124

1. 
   theStack commented at 6:57 pm on October 13, 2019: member

   approaches another part of #16613 (“Functional test suite bottlenecks”)

   As for wallet_backup.py (Commit 581c9be0d8bff46cd68bd6a3bf72f22d11c09aea), the bottleneck is in relaying transactions. By whitelisting the peers, the inventory is transmissioned immediately rather than on average every 5 seconds, speeding up the test significantly:

   before:

   0$ time ./wallet_address_types.py
   1real    1m30.072s
   2user    0m6.478s
   3sys     0m2.298s
   

   with this PR:

   0$ time ./wallet_address_types.py
   1real    0m26.785s
   2user    0m5.525s
   3sys     0m1.888s
   

2. test: speed up wallet_address_types by whitelisting peers (immediate tx relay)

   approaches another part of #16613 ("Functional test suite bottlenecks")
   
   As for wallet_backup.py (Commit 581c9be0d8bff46cd68bd6a3bf72f22d11c09aea), the
   bottleneck is in relaying transactions. By whitelisting the peers, the
   inventory is transmissioned immediately rather than on average every 5 seconds,
   speeding up the test significantly:
   
   before:
   $ time ./wallet_address_types.py
   real    1m30.072s
   user    0m6.478s
   sys     0m2.298s
   
   with this PR:
   $ time ./wallet_address_types.py
   real    0m26.785s
   user    0m5.525s
   sys     0m1.888s

   fba4baa4fa
3. theStack force-pushed on Oct 13, 2019
4. fanquake added the label Tests on Oct 13, 2019
5. fanquake approved
6. 
   fanquake commented at 2:20 pm on October 14, 2019: member

   ACK - fba4baa4fa22fdf96935af1bd6b253c3ad76165f

   master (4765b91f507dc6f44122ed0062e74510577eea29):

   0wallet_address_types.py | ✓ Passed  | 87 s
   

   PR (fba4baa4fa22fdf96935af1bd6b253c3ad76165f):

   0wallet_address_types.py | ✓ Passed  | 37 s
   

7. MarcoFalke referenced this in commit b33c03b0cb on Oct 14, 2019
8. MarcoFalke merged this on Oct 14, 2019
9. MarcoFalke closed this on Oct 14, 2019

   ---

10. deadalnix referenced this in commit 87f67834ec on May 19, 2020
11. MarcoFalke referenced this in commit a57af897ec on Aug 16, 2020
12. sidhujag referenced this in commit 9f7e4e2bb0 on Aug 16, 2020
13. ftrader referenced this in commit f3a0c25c99 on Aug 17, 2020
14. theStack deleted the branch on Dec 1, 2020
15. DrahtBot locked this on Feb 15, 2022

Contributors
theStack fanquake

Labels
Tests