gui: Add toolTip and placeholderText to sign message fields #17125

dannmat commented at 7:03 PM on October 13, 2019: none

When using the Verify Message functionality, I found the input boxes to be rather confusing as they had no guidance for their purpose.

I have added tooltips and labels to aid users when verifying messages in future

fanquake added the label GUI on Oct 13, 2019

in src/qt/signverifymessagedialog.cpp:44 in 2a8ef703e3 outdated

  40 | @@ -41,6 +41,9 @@ SignVerifyMessageDialog::SignVerifyMessageDialog(const PlatformStyle *_platformS
  41 |      GUIUtil::setupAddressWidget(ui->addressIn_SM, this);
  42 |      GUIUtil::setupAddressWidget(ui->addressIn_VM, this);
  43 |  
  44 | +    ui->messageIn_VM->setPlaceholderText(tr("Enter the signed message to verify"));

promag commented at 10:02 PM on October 13, 2019:

Why aren't these in the .ui file?

dannmat commented at 7:44 AM on October 14, 2019:

I tried to keep the changes consistent with the rest of this file, by adding the placeholder text in code

laanwj commented at 9:55 AM on October 14, 2019:

FWIW the historical reason for this is that there was some Qt 4.x version that didn't support placeholder text in the .ui file. Support for Qt4 was dropped ages ago so this is not a concern anymore. Feel free to simply add it in the ui file.

dannmat commented at 10:16 AM on October 14, 2019:

Ahh that makes sense, thank you. I'll redo these changes tonight in the UI file and commit.

dannmat commented at 5:36 PM on October 14, 2019: none

I have changed the placeholder text to be in the UI file instead as per @promag & @laanwj request

MarcoFalke commented at 5:42 PM on October 14, 2019: member

Usually, we squash the commits after a fixup, according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

laanwj commented at 6:31 AM on October 15, 2019: member

ACK after squash

fanquake added the label Waiting for author on Oct 15, 2019

gui: Added label & tooltip for Verify Message labels 610d9384de

dannmat commented at 3:03 PM on October 15, 2019: none

Rebase and Squash done.

promag commented at 3:06 PM on October 15, 2019: member

Code review ACK 610d9384de7f4de861d94c9b1af4fddc8aa57ad9. Nit, commit and title are a little weird. Suggestion: "gui: Add toolTip and placeholderText to sign message fields"

MarcoFalke removed the label Waiting for author on Oct 15, 2019

MarcoFalke commented at 3:07 PM on October 15, 2019: member

ACK 610d9384de7f4de861d94c9b1af4fddc8aa57ad9 (looks good, didn't compile or tested the changes)

dannmat renamed this:
~~gui: Added label & tooltip for Verify Message inputs~~
gui: Add toolTip and placeholderText to sign message fields
on Oct 15, 2019

fanquake approved

fanquake commented at 3:59 PM on October 15, 2019: member

ACK - 610d9384de7f4de861d94c9b1af4fddc8aa57ad9

master (029c65e04cc2826817e6b5b10696c0e390694ae8): master

PR (610d9384de7f4de861d94c9b1af4fddc8aa57ad9):

fanquake referenced this in commit 137b7a2af1 on Oct 15, 2019

fanquake merged this on Oct 15, 2019

fanquake closed this on Oct 15, 2019

luke-jr referenced this in commit fdf0f2a970 on Nov 15, 2019

MarkLTZ referenced this in commit 9c987ad51a on Nov 17, 2019

jasonbcox referenced this in commit 83c5cb0378 on Oct 28, 2020

PastaPastaPasta referenced this in commit 856751778e on Jun 27, 2021

PastaPastaPasta referenced this in commit 625d288800 on Jun 28, 2021

PastaPastaPasta referenced this in commit 75cb4baf66 on Jun 29, 2021

PastaPastaPasta referenced this in commit 502f609f38 on Jul 1, 2021

PastaPastaPasta referenced this in commit f7ae697f70 on Jul 1, 2021

PastaPastaPasta referenced this in commit 74be34a7ac on Jul 12, 2021

PastaPastaPasta referenced this in commit d4bab675c0 on Jul 13, 2021

PastaPastaPasta referenced this in commit 4c5e542c46 on Jul 13, 2021

MarcoFalke locked this on Dec 16, 2021