Remove wallet access to node arguments #17137

1. 
   jnewbery commented at 5:52 pm on October 14, 2019: member

   To better separate the wallet and node, and in preparation for full process separation, the wallet should not access any of the node’s config arguments. Either config interaction should be handled outside the wallet, or the wallet should use a well-defined method in the Chain interface to access the values.

   Currently, the wallet accesses global node arguments in the following locations:

   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/init.cpp#L87 (blocksonly)
   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/init.cpp#L103 (persistmempool)
   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/init.cpp#L123 (sysperms)
   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/init.cpp#L125 (prune)
   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/wallet.cpp#L2742 (limitancestorcount)
   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/wallet.cpp#L2743 (limitdescendantcount)
   • https://github.com/bitcoin/bitcoin/blob/b33c03b0cb82e57eb862542c9d331b7ceb8f3a62/src/wallet/wallet.cpp#L4488 (minrelaytxfee)
2. jnewbery added the label Feature on Oct 14, 2019
3. jnewbery renamed this:
   Remove wallet access to node arguements
   Remove wallet access to node arguments
   on Oct 14, 2019
4. fanquake added the label Wallet on Oct 14, 2019
5. MarcoFalke added the label Brainstorming on Oct 14, 2019
6. MarcoFalke removed the label Feature on Oct 14, 2019
7. 
   ryanofsky commented at 3:35 pm on October 15, 2019: member

   in preparation for full process separation

   In practice, there isn’t an issue in #10102 because the node serializes gArgs and passes it to the wallet when it calls MakeWalletClient. But giving the wallet and node separate arguments is cleaner and would remove the need for this workaround.

8. MarcoFalke referenced this in commit a3af5b5c13 on Oct 15, 2019
9. 
   jnewbery commented at 7:03 pm on April 24, 2020: member

   #17138 removed -limitancestorcount, -limitdescendantcount and -prune
10. 
    Kixunil commented at 4:48 pm on November 30, 2020: none

    Do I understand correctly that after this change Bitcoind will create all files with 77x permissions?
11. PastaPastaPasta referenced this in commit 779c26b54f on Apr 7, 2022
12. PastaPastaPasta referenced this in commit 08967ac0cd on Apr 7, 2022
13. vijaydasmp referenced this in commit d4c1e4d6b7 on Apr 25, 2022
14. vijaydasmp referenced this in commit 85055b8339 on May 10, 2022
15. vijaydasmp referenced this in commit 7b793ae749 on May 19, 2022
16. vijaydasmp referenced this in commit 72579c1c90 on May 19, 2022
17. vijaydasmp referenced this in commit e3b2e974b1 on Jun 14, 2022
18. vijaydasmp referenced this in commit 4dd824e407 on Jun 15, 2022
19. vijaydasmp referenced this in commit 4cd523a483 on Jun 15, 2022
20. vijaydasmp referenced this in commit 61df44b9d0 on Jun 15, 2022
21. vijaydasmp referenced this in commit 621756a362 on Jun 16, 2022
22. vijaydasmp referenced this in commit 9d2a4d66a5 on Jun 16, 2022
23. vijaydasmp referenced this in commit 72bd82dbdd on Jun 17, 2022
24. vijaydasmp referenced this in commit 85e836fa33 on Jun 18, 2022
25. vijaydasmp referenced this in commit 8853b6e1e4 on Jun 18, 2022
26. jnewbery closed this on Jun 20, 2022

    ---

27. knst referenced this in commit 7095834ed1 on Mar 29, 2023
28. UdjinM6 referenced this in commit baa37c345c on Apr 6, 2023
29. DrahtBot locked this on Jun 20, 2023

Contributors
jnewbery ryanofsky Kixunil

Labels
Brainstorming Wallet