doc: Update list of valid PR areas #17172

pull ch4ot1c wants to merge 1 commits into bitcoin:master from ch4ot1c:doc/pr-areas changing 1 files +11 −8

ch4ot1c commented at 12:52 PM on October 17, 2019: contributor
Updates list of Pull Request areas / prefixes in CONTRIBUTING.md:
- Adds init, cli, depends, contrib
- Removes lib
- Changes script to scripts
doc: Update list of valid PR areas/prefixes 7afc29a0ab
fanquake added the label Docs on Oct 17, 2019

in CONTRIBUTING.md:82 in 7afc29a0ab

  78 | @@ -79,19 +79,22 @@ about Git.
  79 |  The title of the pull request should be prefixed by the component or area that
  80 |  the pull request affects. Valid areas as:
  81 |  
  82 | -  - `consensus` for changes to consensus critical code

MarcoFalke commented at 2:30 PM on October 17, 2019:

why is this (re)moved?

ch4ot1c commented at 9:32 PM on October 17, 2019:

Figured they should be ordered by simplicity.

jonatack commented at 2:55 PM on October 17, 2019: member

I don't see the value of these changes.
hebasto commented at 4:02 PM on October 17, 2019: member
* Changes `script` to `scripts`
See: #16484 (comment)
laanwj commented at 6:00 PM on October 17, 2019: member

I don't see the value of these changes.

I agree. I'm also not sure this is worth doing.
fanquake closed this on Oct 17, 2019
ch4ot1c commented at 9:34 PM on October 17, 2019: contributor

Alright - I thought these would be validated by commit-script-check at some point; I guess these are relaxed instructions.

As for scripts vs script, I thought it would help avoid misuses like #16653 (bitcoin's script language vs utility scripts)
DrahtBot locked this on Dec 16, 2021

Contributors

Labels