doc: update labels in CONTRIBUTING.md #16484

MarcoFalke commented at 12:33 PM on July 29, 2019: member

None of the examples in the "trivial" area are acceptable pull requests, unless they are acceptable in a different area (like "doc" or "log").

Fix that by removing the "trivial" area.

fanquake added the label Docs on Jul 29, 2019

laanwj commented at 12:54 PM on July 29, 2019: member

Agree, 'trivial' doesn't help with categorizing at all.

ACK faf216bc713c36d7b3fac424973c8b89d235ab83

MarcoFalke added this to the milestone 0.19.0 on Jul 29, 2019

in CONTRIBUTING.md:85 in faf216bc71 outdated

  81 | @@ -82,19 +82,12 @@ the pull request affects. Valid areas as:
  82 |    - *Consensus* for changes to consensus critical code
  83 |    - *Docs* for changes to the documentation
  84 |    - *Qt* for changes to bitcoin-qt
  85 | +  - *Log* Changes to log messages

ryanofsky commented at 3:23 PM on July 29, 2019:

Would say "Logging" or "Logs" to be consistent with "Mining" below or "Docs" above. "Log" isn't a component of bitcoin that you'd refer to with a singular noun.

jonatack commented at 3:58 PM on July 29, 2019:

I don't disagree, yet suggested the opposite for brevity and what is often seen in practice.

ryanofsky approved

ryanofsky commented at 3:26 PM on July 29, 2019: member

Super ACK faf216bc713c36d7b3fac424973c8b89d235ab83. I always thought this section was dumb, because it uses a different definition of "trivial" than I've ever seen before (indicating an absence of side effects, rather than simplicity).

MarcoFalke force-pushed on Jul 29, 2019

MarcoFalke commented at 3:32 PM on July 29, 2019: member

Added missing s, as requested by @ryanofsky

ryanofsky approved

ryanofsky commented at 3:35 PM on July 29, 2019: member

ACK fab41be72e535d5782e21bbfce15a9906d233efc

promag commented at 3:42 PM on July 29, 2019: member

ACK fab41be.

in CONTRIBUTING.md:85 in fab41be72e outdated

  81 | @@ -82,19 +82,12 @@ the pull request affects. Valid areas as:
  82 |    - *Consensus* for changes to consensus critical code
  83 |    - *Docs* for changes to the documentation
  84 |    - *Qt* for changes to bitcoin-qt
  85 | +  - *Logs* Changes to log messages

jonatack commented at 3:56 PM on July 29, 2019:

Good addition. Not a strong opinion, but while here, perhaps shorten to log as well as docs to doc and tests to test... since they are shorter and often used in practice. For brevity, scripts and tools could be just script/tool, and utils and libraries just util/lib.

jonatack commented at 3:56 PM on July 29, 2019: member

ACK. Suggest updating the PR title to "doc: update labels in CONTRIBUTING.md"

in CONTRIBUTING.md:102 in fab41be72e outdated

  95 | @@ -103,7 +96,7 @@ Examples:
  96 |      Consensus: Add new opcode for BIP-XXXX OP_CHECKAWESOMESIG
  97 |      Net: Automatically create hidden service, listen on Tor
  98 |      Qt: Add feed bump button
  99 | -    Trivial: Fix typo in init.cpp
 100 | +    Logs: Fix typo in log message
 101 |  
 102 |  Note that translations should not be submitted as pull requests, please see
 103 |  [Translation Process](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md)

jonatack commented at 4:01 PM on July 29, 2019:

nit: extra whitespace at the end of this line that can be removed while touching this file.

jonatack commented at 4:13 PM on July 29, 2019:

nit: also extra whitespace at the end of all the 4 last lines of this file except the last one, that can be removed while touching this file

in CONTRIBUTING.md:87 in fab41be72e outdated

  81 | @@ -82,19 +82,12 @@ the pull request affects. Valid areas as:
  82 |    - *Consensus* for changes to consensus critical code
  83 |    - *Docs* for changes to the documentation
  84 |    - *Qt* for changes to bitcoin-qt
  85 | +  - *Logs* Changes to log messages
  86 |    - *Mining* for changes to the mining code
  87 |    - *Net* or *P2P* for changes to the peer-to-peer network code

jonatack commented at 4:03 PM on July 29, 2019:

Could add refactoring. Often seen in practice.

MarcoFalke force-pushed on Jul 29, 2019

doc: update labels in CONTRIBUTING.md faa88d0b5c

MarcoFalke force-pushed on Jul 29, 2019

MarcoFalke commented at 5:53 PM on July 29, 2019: member

Dropped the s again, as requested by @jonatack

MarcoFalke renamed this:
~~doc: Remove "trivial" label in CONTRIBUTING~~
doc: update labels in CONTRIBUTING.md
on Jul 29, 2019

jonatack commented at 6:03 PM on July 29, 2019: member

ACK faa88d0b5c7f6e317d0e35daef28d320801f1bb5

fanquake approved

fanquake commented at 3:49 AM on July 30, 2019: member

ACK faa88d0b5c7f6e317d0e35daef28d320801f1bb5 - agree that trivial was pretty useless and that the meaning was unclear. Other changes look fine. Surprised the white space linter hasn't been having a field day in this file.

fanquake merged this on Jul 30, 2019

fanquake closed this on Jul 30, 2019

fanquake referenced this in commit 33894612c0 on Jul 30, 2019

MarcoFalke deleted the branch on Jul 30, 2019

Munkybooty referenced this in commit c945251246 on Nov 17, 2021

Munkybooty referenced this in commit 71c735872d on Nov 18, 2021

Munkybooty referenced this in commit 2b1fa4c6c6 on Nov 24, 2021

Munkybooty referenced this in commit 09b4ec2c50 on Nov 30, 2021

Munkybooty referenced this in commit d1d00d777a on Dec 15, 2021

Munkybooty referenced this in commit a1be7f2c0a on Dec 17, 2021

Munkybooty referenced this in commit ff60da539e on Dec 24, 2021

Munkybooty referenced this in commit b8d4f4f6ae on Jan 19, 2022

Munkybooty referenced this in commit 6fe1ee0f19 on Jan 24, 2022

Munkybooty referenced this in commit dbdfa1b3d0 on Jan 30, 2022

DrahtBot locked this on Feb 15, 2022