gui: Hide or grey out used addresses #17174

issue MarcoFalke openend this issue on October 17, 2019

MarcoFalke commented at 1:47 pm on October 17, 2019: member

The gui keeps track of some addresses in the “receiving addresses” and “sending addresses” tabs. In light of address reuse and accidental double-payments, it could make sense to hide or dull out addresses which have been used. Maybe even show the txid.
MarcoFalke added the label Feature on Oct 17, 2019
MarcoFalke added the label Brainstorming on Oct 17, 2019
MarcoFalke added the label GUI on Oct 17, 2019
za-kk commented at 8:00 pm on October 17, 2019: contributor

Agreed, willing to work on this if consensus thinks it would be a valuable change.
MarcoFalke removed the label Brainstorming on Oct 17, 2019
MarcoFalke commented at 8:19 pm on October 17, 2019: member

The issue has three “:+1:”, which means overall agreement, I guess
za-kk commented at 8:22 pm on October 17, 2019: contributor

Nice, will start working on this and open a PR once complete 👍
promag commented at 12:03 pm on November 2, 2019: member

Concept ACK. Do we already track used addresses in the wallet (beside keypool)? If not then I think we should start by doing it otherwise implementing this can hurt the GUI for big wallets. Or am I missing something?
laanwj added the label Wallet on Nov 2, 2019
za-kk commented at 12:36 pm on November 2, 2019: contributor

We already track used addresses in the address book via the SetUsedDestinationState, however this is only when the wallet has the avoid_reuse flag set.
promag commented at 4:32 pm on November 2, 2019: member

only when the wallet has the avoid_reuse flag set.

Sounds reasonable to support just that for now.
fanquake commented at 2:42 am on January 21, 2022: member

I’ve moved this over to the GUI repo: https://github.com/bitcoin-core/gui/issues/528.
fanquake closed this on Jan 21, 2022
DrahtBot locked this on Jan 21, 2023

Contributors
MarcoFalke za-kk promag fanquake

Labels
Feature GUI Wallet