gui: Improved tooltip for send amount field #17180

JeremyCrookshank commented at 6:30 PM on October 17, 2019: contributor

I noticed that on Bitcoin sends the tooltip wasn't very clear for new users and I hope my PR is more concise. If it needs changing more will happily change too :+1: IMG_20191017_192739

fanquake added the label GUI on Oct 17, 2019

MarcoFalke commented at 6:38 PM on October 17, 2019: member

Is this a leftover from BIP 70?

ACK

dannmat commented at 7:58 PM on October 17, 2019: none

ACK

JeremyCrookshank commented at 8:06 PM on October 17, 2019: contributor

Is this a leftover from BIP 70?

ACK

It was added here https://github.com/bitcoin/bitcoin/blob/c6c97e0f4e3d9d8d5b8a1e60174e9ff11e70b6c1/src/qt/forms/sendcoinsentry.ui

MarcoFalke added this to the milestone 0.20.0 on Oct 17, 2019

kristapsk approved

kristapsk commented at 6:33 PM on October 18, 2019: contributor

ACK 31cf33132730318e9fadcc63c17716e36e4250ad

MarcoFalke commented at 7:42 PM on October 18, 2019: member

It was added here https://github.com/bitcoin/bitcoin/blob/c6c97e0f4e3d9d8d5b8a1e60174e9ff11e70b6c1/src/qt/forms/sendcoinsentry.ui

Thanks for looking that up

ACK 31cf33132730318e9fadcc63c17716e36e4250ad

MarcoFalke removed this from the milestone 0.20.0 on Oct 18, 2019

fanquake renamed this:
~~gui: Improved wording/explanation of Bitcoin sends amount box~~
gui: Improved tooltip for send amount field
on Oct 18, 2019

fanquake approved

fanquake commented at 9:13 PM on October 18, 2019: member

ACK 31cf33132730318e9fadcc63c17716e36e4250ad

master (fd3b4e422d6826f53e0f283148a9ee0701ffe468): master

PR (31cf33132730318e9fadcc63c17716e36e4250ad):

GChuf commented at 11:39 AM on October 20, 2019: contributor

ACK 31cf33132730318e9fadcc63c17716e36e4250ad

promag commented at 12:08 PM on October 20, 2019: member

How about "the amount to send" or "the amount to send in the selected unit"?

laanwj commented at 10:15 AM on October 21, 2019: member

Agree with promag. I don't think you even need to mention bitcoin. I'd prefer "the amount to send in the selected unit".

fanquake added the label Waiting for author on Oct 21, 2019

JeremyCrookshank commented at 11:39 AM on October 21, 2019: contributor

How about if I have the tooltip say the unit selected?

IE The amount of Satoshis to send The amount of mBTC to send

promag commented at 11:44 AM on October 21, 2019: member

Probably nice but IMO not worth the effort. A constant tooltip is fine.

GChuf commented at 2:10 PM on October 21, 2019: contributor

I agree with "amount to send" or "amount to send in selected unit"

JeremyCrookshank force-pushed on Oct 21, 2019

JeremyCrookshank closed this on Oct 21, 2019

JeremyCrookshank deleted the branch on Oct 21, 2019

JeremyCrookshank reopened this on Oct 21, 2019

JeremyCrookshank commented at 11:00 PM on October 21, 2019: contributor

Had some issues with Git(still need to squash them?). I have however committed my PR which means the tooltip now reflects the selected unit appropriately. I will post photos tomorrow unless someone beats me to it.

in src/qt/forms/sendcoinsentry.ui:21 in 60d226efa2 outdated

  17 | @@ -18,7 +18,7 @@
  18 |    </property>
  19 |    <widget class="QFrame" name="SendCoins">
  20 |     <property name="toolTip">
  21 | -    <string>This is a normal payment.</string>
  22 | +    <string>The amount of Bitcoin to send</string>

promag commented at 8:30 AM on October 22, 2019:

Maybe this tooltip could be removed?

laanwj commented at 11:14 AM on October 22, 2019:

Yes, either keep it here or in the code, not both. This generates a spurious translation message.

JeremyCrookshank commented at 11:30 AM on October 22, 2019:

I meant to remove this for the dynamic tooltip

in src/qt/bitcoinamountfield.cpp:329 in 60d226efa2 outdated

 324 | @@ -325,6 +325,9 @@ void BitcoinAmountField::unitChanged(int idx)
 325 |      // Use description tooltip for current unit for the combobox
 326 |      unit->setToolTip(unit->itemData(idx, Qt::ToolTipRole).toString());
 327 |  
 328 | +    // Update send coins input box's tooltip
 329 | +    amount->setToolTip("The amount of " + unit->itemData(idx, Qt::DisplayRole).toString() + " to send");

promag commented at 8:32 AM on October 22, 2019:

Should be translated, see https://doc.qt.io/qt-5/qobject.html#tr.

laanwj commented at 11:14 AM on October 22, 2019:

Personally, I don't think it's useful to parametrize the tooltip on the selected unit. This also makes translation harder. Just mention "the selected unit" in text.

JeremyCrookshank commented at 11:33 AM on October 22, 2019:

Doesn't it seem more user friendly to have it reflect the selected unit instead of saying the unit?

I can change it back to what you suggest through just thought it was a nice change 😀

promag commented at 11:34 AM on October 22, 2019:

I also tend to prefer the constant tooltip, the unit is already right next to the amount field.

JeremyCrookshank commented at 11:37 AM on October 22, 2019:

Even if we don't go with the dynamic tooltip I'm still happy that I learnt how to and for it to work 😀

JeremyCrookshank closed this on Oct 22, 2019

JeremyCrookshank force-pushed on Oct 22, 2019

static tooltip 088a730fe6

JeremyCrookshank reopened this on Oct 22, 2019

JeremyCrookshank commented at 7:38 PM on October 22, 2019: contributor

I have made the changes as requested

in src/qt/forms/sendcoinsentry.ui:21 in 088a730fe6

  17 | @@ -18,7 +18,7 @@
  18 |    </property>
  19 |    <widget class="QFrame" name="SendCoins">
  20 |     <property name="toolTip">
  21 | -    <string>This is a normal payment.</string>
  22 | +    <string>The amount to send in the selected unit</string>

promag commented at 8:41 AM on October 23, 2019:

Could be the payAmount tooltip, in line 168?

laanwj commented at 10:01 AM on October 23, 2019:

Let's not keep drawing this out. The previous tooltip was wrong and this one is correct.

laanwj commented at 10:00 AM on October 23, 2019: member

ACK 088a730fe6f893d43b55ec52e6b5080fd445dd9e

laanwj referenced this in commit ceda6e8b74 on Oct 23, 2019

laanwj merged this on Oct 23, 2019

laanwj closed this on Oct 23, 2019

laanwj removed the label Waiting for author on Oct 24, 2019

luke-jr referenced this in commit 2814906357 on Nov 15, 2019

jasonbcox referenced this in commit 99551732f3 on Oct 30, 2020

PastaPastaPasta referenced this in commit 034aff05cd on Jun 27, 2021

PastaPastaPasta referenced this in commit d3180bd53a on Jun 28, 2021

PastaPastaPasta referenced this in commit 3ece0977e7 on Jun 29, 2021

PastaPastaPasta referenced this in commit f9902dc94e on Jul 1, 2021

PastaPastaPasta referenced this in commit 3d539e909b on Jul 1, 2021

PastaPastaPasta referenced this in commit f0e75a19b4 on Jul 12, 2021

PastaPastaPasta referenced this in commit 4ad9c9b666 on Jul 13, 2021

PastaPastaPasta referenced this in commit 44e79f0740 on Jul 13, 2021

DrahtBot locked this on Dec 16, 2021