invalid zmq argument syntax on windows causes abort #17185

Version: 0.18.1 (64-bit) on Windows 10.0.18362.418

Using the following config, bitcoind crashes.

This is not #15808 because the assignments are within the regtest section (see the comment on that issue).

Seems like it is #7496 reappearing.

[regtest]
rpcuser=user
rpcpassword=pass
rpcport=8332
server=1
zmqpubrawblock=127.0.0.1:40000
zmqpubrawtx=127.0.0.1:40000

PS C:\Program Files\Bitcoin\daemon> .\bitcoind -regtest -txindex
2019-10-18T07:05:41Z Bitcoin Core version v0.18.1 (release build)
2019-10-18T07:05:41Z Validating signatures for all blocks.
2019-10-18T07:05:41Z Setting nMinimumChainWork=0000000000000000000000000000000000000000000000000000000000000000
2019-10-18T07:05:41Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2019-10-18T07:05:41Z Using RdSeed as additional entropy source
2019-10-18T07:05:41Z Using RdRand as an additional entropy source
2019-10-18T07:05:41Z Default data directory C:\Users\janus\AppData\Roaming\Bitcoin
2019-10-18T07:05:41Z Using data directory C:\Users\janus\AppData\Roaming\Bitcoin\regtest
2019-10-18T07:05:41Z Config file: C:\Users\janus\AppData\Roaming\Bitcoin\bitcoin.conf
2019-10-18T07:05:41Z Using at most 125 automatic connections (2048 file descriptors available)
2019-10-18T07:05:41Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2019-10-18T07:05:41Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2019-10-18T07:05:41Z Using 4 threads for script verification
2019-10-18T07:05:41Z scheduler thread start
2019-10-18T07:05:41Z libevent: getaddrinfo: nodename nor servname provided, or not known
2019-10-18T07:05:41Z Binding RPC on address ::1 port 8332 failed.
2019-10-18T07:05:41Z HTTP: creating work queue of depth 16
2019-10-18T07:05:41Z Config options rpcuser and rpcpassword will soon be deprecated. Locally-run instances may remove rpcuser to use cookie-based auth, or may be replaced with rpcauth. Please see share/rpcauth for rpcauth auth generation.
2019-10-18T07:05:41Z HTTP: starting 4 worker threads
2019-10-18T07:05:41Z Using wallet directory C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets
2019-10-18T07:05:41Z init message: Verifying wallet(s)...
2019-10-18T07:05:41Z Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-10-18T07:05:41Z Using wallet C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets
2019-10-18T07:05:41Z BerkeleyEnvironment::Open: LogDir=C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets\database ErrorFile=C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets\db.log
2019-10-18T07:05:42Z init message: Loading banlist...
2019-10-18T07:05:42Z ERROR: DeserializeFileDB: Failed to open file C:\Users\janus\AppData\Roaming\Bitcoin\regtest\banlist.dat
2019-10-18T07:05:42Z Invalid or missing banlist.dat; recreating
Assertion failed!

Program: C:\Program Files\Bitcoin\daemon\bitcoind.exe
File: zmq/zmqpublishnotifier.cpp, Line 115

Expression: psocket
PS C:\Program Files\Bitcoin\daemon>

Same issue in WSL and when running in an administrator prompt. Dunno why the port bind on 8332 is failing. Don't think I have anything running there, if I try to connect netcat to that local port, I get 'Connection Refused'.

This is the assertion it crashes on:

void CZMQAbstractPublishNotifier::Shutdown()
{
    assert(psocket);

• The bind problem is not fatal (it means it cannot bind on IPv6 localhost, but it will still have bound on IPv4 localhost), and continues after it.
• The missing banlist is also not fatal.

So I expect it's the zmq arguments.

Can you try a different syntax?

zmqpubrawblock=tcp://127.0.0.1:40000
zmqpubrawtx=tcp://127.0.0.1:40000

The syntax you propose works, but i don't think it should crash with invalid syntax. It would make sense to default to tcp since it is arguably more popular than named pipes.

On Fri, 18 Oct 2019, 04:12 Wladimir J. van der Laan, < notifications@github.com> wrote:

This is the assertion it crashes on:

void CZMQAbstractPublishNotifier::Shutdown() { assert(psocket);

• The bind problem is not fatal (it means it cannot bind on IPv6 localhost, but it will still have bound on IPv4 localhost), and continues after it.
• The missing banlist is also not fatal.

So I expect it's the zmq arguments.

Can you try a different syntax?

zmqpubrawblock=tcp://127.0.0.1:40000 zmqpubrawtx=tcp://127.0.0.1:40000

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/17185?email_source=notifications&email_token=AACFK5YI3XQEWPGPVYA7DZLQPF4YFA5CNFSM4JCDPC7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBTPGNQ#issuecomment-543617846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFK52STQFUUDUOMMSGVK3QPF4YFANCNFSM4JCDPC7A .

I agree it should not crash. Not sure if it should default to tpc but at least should fail to start with an error message.

In macos I get:

./src/bitcoind -regtest -debug -zmqpubrawtx=foo

...
2019-11-02T16:29:37Z zmq: Error: Failed to bind address, errno=Invalid argument
2019-11-02T16:29:37Z zmq: Notifier pubrawtx failed (address = foo)
2019-11-02T16:29:37Z zmq: Shutdown notification interface
2019-11-02T16:29:37Z zmq: Shutdown notifier pubrawtx at foo
...

And doesn't abort. Can you also check the output with -debug argument?

@promag log with -debug , as you requested:

PS C:\Program Files\Bitcoin\daemon> .\bitcoind -regtest -txindex -debug
2019-11-09T19:04:17Z Bitcoin Core version v0.18.1 (release build)
2019-11-09T19:04:17Z Validating signatures for all blocks.
2019-11-09T19:04:17Z Setting nMinimumChainWork=0000000000000000000000000000000000000000000000000000000000000000
2019-11-09T19:04:17Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2019-11-09T19:04:17Z Using RdSeed as additional entropy source
2019-11-09T19:04:17Z Using RdRand as an additional entropy source
2019-11-09T19:04:17Z Default data directory C:\Users\janus\AppData\Roaming\Bitcoin
2019-11-09T19:04:17Z Using data directory C:\Users\janus\AppData\Roaming\Bitcoin\regtest
2019-11-09T19:04:17Z Config file: C:\Users\janus\AppData\Roaming\Bitcoin\bitcoin.conf
2019-11-09T19:04:17Z Using at most 125 automatic connections (2048 file descriptors available)
2019-11-09T19:04:17Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2019-11-09T19:04:17Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2019-11-09T19:04:17Z Using 4 threads for script verification
2019-11-09T19:04:17Z scheduler thread start
2019-11-09T19:04:17Z Allowing HTTP connections from: 127.0.0.0/8 ::1/128
2019-11-09T19:04:17Z Binding RPC on address ::1 port 8332
2019-11-09T19:04:17Z libevent: getaddrinfo: nodename nor servname provided, or not known
2019-11-09T19:04:17Z Binding RPC on address ::1 port 8332 failed.
2019-11-09T19:04:17Z Binding RPC on address 127.0.0.1 port 8332
2019-11-09T19:04:17Z Initialized HTTP server
2019-11-09T19:04:17Z HTTP: creating work queue of depth 16
2019-11-09T19:04:17Z Starting RPC
2019-11-09T19:04:17Z Starting HTTP RPC server
2019-11-09T19:04:17Z Config options rpcuser and rpcpassword will soon be deprecated. Locally-run instances may remove rpcuser to use cookie-based auth, or may be replaced with rpcauth. Please see share/rpcauth for rpcauth auth generation.
2019-11-09T19:04:17Z Registering HTTP handler for / (exactmatch 1)
2019-11-09T19:04:17Z Registering HTTP handler for /wallet/ (exactmatch 0)
2019-11-09T19:04:17Z Starting HTTP server
2019-11-09T19:04:17Z HTTP: starting 4 worker threads
2019-11-09T19:04:17Z Entering http event loop
2019-11-09T19:04:17Z Using wallet directory C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets
2019-11-09T19:04:17Z init message: Verifying wallet(s)...
2019-11-09T19:04:17Z Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-11-09T19:04:17Z Using wallet C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets
2019-11-09T19:04:17Z BerkeleyEnvironment::Open: LogDir=C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets\database ErrorFile=C:\Users\janus\AppData\Roaming\Bitcoin\regtest\wallets\db.log
2019-11-09T19:04:17Z init message: Loading banlist...
2019-11-09T19:04:17Z Loaded 0 banned node ips/subnets from banlist.dat  0ms
2019-11-09T19:04:17Z net: setting try another outbound peer=false
2019-11-09T19:04:17Z zmq: version 4.3.1
2019-11-09T19:04:17Z zmq: Initialize notification interface
2019-11-09T19:04:17Z zmq: Outbound message high water mark for pubrawblock at 127.0.0.1:40000 is 1000
2019-11-09T19:04:17Z zmq: Error: Failed to bind address, errno=Invalid argument
2019-11-09T19:04:17Z zmq: Notifier pubrawblock failed (address = 127.0.0.1:40000)
2019-11-09T19:04:17Z zmq: Shutdown notification interface
2019-11-09T19:04:17Z zmq: Shutdown notifier pubrawblock at 127.0.0.1:40000
2019-11-09T19:04:17Z zmq: Shutdown notifier pubrawtx at 127.0.0.1:40001
Assertion failed!

Program: C:\Program Files\Bitcoin\daemon\bitcoind.exe
File: zmq/zmqpublishnotifier.cpp, Line 115

Expression: psocket

It would make sense to default to tcp since it is arguably more popular than named pipes.

I disagree that the project should be making these kinds of calls. The arguments are provided as-is to zmq, it's up to the user to provide correct input. Ignoring invalid or ambigious input is even worse.

But I agree that crashing on an error is bad user experience, it should just print an error message and exit.

This is also happens in other operative systems.