gui: Add placeholder text to the sign message field #17186

Danny-Scott commented at 8:10 AM on October 18, 2019: contributor

When using the sign message functionality I noticed the "message" field had no label or placeholder text to highlight what it's for.

I've added the placeholder text to match the tool tip to help it be more user friendly.

hebasto commented at 8:14 AM on October 18, 2019: member

@Danny-Scott Thank you for contributing. Could you add screenshots (master and with this PR) to the OP?

Danny-Scott commented at 8:25 AM on October 18, 2019: contributor

Screenshots attached - Thanks, hopefully the first of many contributions.

Master master

PR Danny-PR

laanwj commented at 8:51 AM on October 18, 2019: member

ACK

DrahtBot added the label GUI on Oct 18, 2019

in src/qt/forms/signverifymessagedialog.ui:103 in f956160866 outdated

  98 | @@ -99,6 +99,9 @@
  99 |           <property name="toolTip">
 100 |            <string>Enter the message you want to sign here</string>
 101 |           </property>
 102 | +         <property name="placeholderText">
 103 | +            <string>Enter the message you want to sign here</string>

hebasto commented at 10:18 AM on October 18, 2019:

nit: could follow indentation style?

          <string>Enter the message you want to sign here</string>

hebasto approved

hebasto commented at 10:20 AM on October 18, 2019: member

ACK f956160866f14aca448a3201734df1f74174d038, tested on Linux Mint 19.2.

master (4daadce36cfe9baa63c4d7d70de027add03a00df): Screenshot from 2019-10-18 13-07-07

PR (f956160866f14aca448a3201734df1f74174d038): Screenshot from 2019-10-18 13-19-18

in src/qt/forms/signverifymessagedialog.ui:104 in f185d1edbf outdated

  98 | @@ -99,6 +99,9 @@
  99 |           <property name="toolTip">
 100 |            <string>Enter the message you want to sign here</string>
 101 |           </property>
 102 | +         <property name="placeholderText">
 103 | +          <string>Enter the message you want to sign here</string>
 104 | +          </property>

hebasto commented at 10:34 AM on October 18, 2019:

         </property>

and squash to one commit please ;)

gui: Add placeholder text to the sign message field 7005d6ab8f

hebasto commented at 11:22 AM on October 18, 2019: member

Re-ACK 0b27b3e6a9b38c1a25852c438e2d1ab421a7718b, could squash please?

Danny-Scott force-pushed on Oct 18, 2019

Danny-Scott commented at 11:24 AM on October 18, 2019: contributor

Rebased and squashed.

Thanks

hebasto commented at 11:25 AM on October 18, 2019: member

Re-ACK 7005d6ab8f4393545ec27f528d8c03fc4516ddab

fanquake approved

fanquake commented at 12:14 PM on October 18, 2019: member

ACK 7005d6ab8f4393545ec27f528d8c03fc4516ddab

master (b9b58f8f687e1c718ed48274345baeaa3d9d08d4): master

pr (7005d6ab8f4393545ec27f528d8c03fc4516ddab):

fanquake referenced this in commit f2a094884d on Oct 18, 2019

fanquake merged this on Oct 18, 2019

fanquake closed this on Oct 18, 2019

luke-jr referenced this in commit 53e5cd35ef on Nov 15, 2019

MarkLTZ referenced this in commit d5ce9736b4 on Nov 17, 2019

deadalnix referenced this in commit a542eb6e82 on Oct 28, 2020

PastaPastaPasta referenced this in commit 76d830e8e6 on Jun 27, 2021

PastaPastaPasta referenced this in commit eaa01f2276 on Jun 28, 2021

PastaPastaPasta referenced this in commit 03fff4f967 on Jun 29, 2021

PastaPastaPasta referenced this in commit 706387b73c on Jul 1, 2021

PastaPastaPasta referenced this in commit 76d67a6366 on Jul 1, 2021

PastaPastaPasta referenced this in commit c3cd0018b9 on Jul 12, 2021

PastaPastaPasta referenced this in commit b94beb1c0c on Jul 13, 2021

PastaPastaPasta referenced this in commit 062e61dc4a on Jul 13, 2021

DrahtBot locked this on Dec 16, 2021