tests: Remove no longer needed UBSan suppressions (issues fixed). Add documentation. #17209

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:update-ubsan-suppressions changing 1 files +11 −2

practicalswift commented at 6:35 PM on October 21, 2019: contributor

Remove no longer needed UBSan suppressions (issues fixed). Add documentation.

This PR is the CI-only subset of #17208 (which touches code).

From a fuzzing perspective it would be really nice to be able to run UBSan with as few suppressions as possible :)
tests: Remove no longer needed UBSan suppressions (issues fixed). Add documentation. 0616138a07
fanquake added the label Tests on Oct 21, 2019
DrahtBot commented at 10:26 PM on October 21, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17208 (Make all tests pass UBSan without using any UBSan suppressions by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 1:28 PM on October 22, 2019: member

When were they fixed?
practicalswift commented at 2:31 PM on October 22, 2019: contributor

@MarcoFalke

AFAICT the bool:wallet/wallet.cpp was fixed by me in #13546 (comment) (wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...)).

I don't know when the vptr:fs.cpp issue was fixed.
MarcoFalke referenced this in commit 9dd6bbba61 on Oct 22, 2019
MarcoFalke merged this on Oct 22, 2019
MarcoFalke closed this on Oct 22, 2019
jasonbcox referenced this in commit 4b91fddee8 on Oct 30, 2020
practicalswift deleted the branch on Apr 10, 2021
PastaPastaPasta referenced this in commit d045e206c0 on Sep 11, 2021
PastaPastaPasta referenced this in commit 7d94eabc20 on Sep 11, 2021
PastaPastaPasta referenced this in commit 93b356596f on Sep 12, 2021
PastaPastaPasta referenced this in commit acdebbb238 on Sep 12, 2021
PastaPastaPasta referenced this in commit 877c436049 on Sep 12, 2021
PastaPastaPasta referenced this in commit 0bfae99265 on Sep 14, 2021
PastaPastaPasta referenced this in commit ac130b6c03 on Sep 14, 2021
Munkybooty referenced this in commit 4eec04f615 on Apr 29, 2022
Munkybooty referenced this in commit cf581a76ca on May 12, 2022
Munkybooty referenced this in commit 13ea42cd67 on May 12, 2022
Munkybooty referenced this in commit abee458dee on May 17, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#17208 Make all tests pass UBSan without using any UBSan suppressions

tests: Remove no longer needed UBSan suppressions (issues fixed). Add documentation. #17209

Conflicts