qt: Make bech32 opt out #17210

pull emilengler wants to merge 1 commits into bitcoin:master from emilengler:2019-10-bech32-opt-out changing 2 files +7 −7

emilengler commented at 6:44 PM on October 21, 2019: contributor

This pull requests makes the Bech32 checkbox to a P2SH segwit checkbox and makes it therefore a different kind of opt out.

Because Bech32 is standard now in Bitcoin-Qt, it shouldn't be extra mentioned IMO. Although I'm not a marketing expert I still think it is better to use this approach because I personally unchecked all check boxes where I don't know what they do (you may accidentally sign up for a spam newsletter then).
qt: Make bech32 opt out 4fd3d4dba9
fanquake added the label GUI on Oct 21, 2019
promag commented at 10:31 AM on October 22, 2019: member

I don't think this is correct, if checked it can use legacy type?
emilengler commented at 11:41 AM on October 22, 2019: contributor

@promag IT will do the same that is done if the current box is being unchecked
MarcoFalke commented at 12:26 PM on October 22, 2019: member

I slightly prefer the way it was, no strong opinion though
laanwj commented at 10:56 AM on October 23, 2019: member

I slightly prefer the way it was, no strong opinion though

Same, ~0 on this.
fanquake commented at 12:55 PM on October 23, 2019: member

Agree.
fanquake closed this on Oct 23, 2019
emilengler deleted the branch on Oct 23, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels