tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. #17225

1. 
   practicalswift commented at 10:16 am on October 23, 2019: contributor

   Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible.
2. fanquake added the label Tests on Oct 23, 2019
3. 
   DrahtBot commented at 10:35 am on October 23, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17071 (tests: Add fuzzing harness for CheckBlock(…) and other CBlock related functions by practicalswift)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. practicalswift force-pushed on Oct 23, 2019
5. practicalswift force-pushed on Oct 24, 2019
6. DrahtBot added the label Needs rebase on Oct 24, 2019
7. practicalswift force-pushed on Oct 24, 2019
8. DrahtBot removed the label Needs rebase on Oct 24, 2019
9. DrahtBot added the label Needs rebase on Oct 25, 2019
10. practicalswift force-pushed on Oct 25, 2019
11. DrahtBot removed the label Needs rebase on Oct 25, 2019
12. 
    practicalswift commented at 11:30 pm on October 29, 2019: contributor

    @MarcoFalke If possible it would be nice to get the serialization fuzzing PR:s #17225 and #17051 in so that the currently under review PR #10785 (“Serialization improvements”) can be easily fuzz tested :)
13. DrahtBot added the label Needs rebase on Oct 30, 2019
14. 
    practicalswift commented at 9:17 pm on October 30, 2019: contributor

    Rebased!
15. practicalswift force-pushed on Oct 30, 2019
16. DrahtBot removed the label Needs rebase on Oct 30, 2019
17. DrahtBot added the label Needs rebase on Nov 18, 2019
18. practicalswift force-pushed on Nov 21, 2019
19. 
    practicalswift commented at 5:54 pm on November 21, 2019: contributor

    Rebased! :)
20. DrahtBot removed the label Needs rebase on Nov 21, 2019
21. 
    practicalswift commented at 8:05 am on November 28, 2019: contributor

    @MarcoFalke Can we move forward with this one? The current deserialization/serialization fuzzing is really lacking so this PR should be a clear improvement. I’m afraid bugs might sneak in unnecessarily if we don’t improve our fuzz testing :)
22. DrahtBot added the label Needs rebase on Dec 6, 2019
23. tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. Avoid code repetition. 709afb2a7d
24. practicalswift force-pushed on Dec 6, 2019
25. 
    practicalswift commented at 9:17 am on December 6, 2019: contributor

    Rebased! :)
26. DrahtBot removed the label Needs rebase on Dec 6, 2019
27. 
    MarcoFalke commented at 8:07 pm on December 9, 2019: member

    ACK 709afb2a7de283a9188e7df51476830012e0a4e5 🍲

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3ACK 709afb2a7de283a9188e7df51476830012e0a4e5 🍲
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUiRVAv9H5qQWzA2afXR5AbtSkKESM0ou1s8zx75A1qmnTCjkbR2c1zs9uuzqfil
     8oP5XQeUTdr7PjM4Y5P3X5dzdxPuUH0UZlGKRgnPHBWaUpUhGvUb6cD1QeZmE005V
     9Pc1iQoh7gE9e/4iMVm7zLb+dtJdvVKqCo7+SyOKIw5CUeu7sZWA2OrCzUNBxSUnY
    10l1/ZlX1EEvUM2rWxeCGRfbwCc6bCp+Yxww5GasYwWmMsUM9wPX3jOxRtzXUcfTTc
    11P4gSG0nJcIw5UhEWrIy4tf9gSjP8GMuclQDlr145zSLG3DMSey/tbM4IJSPX0/y6
    12LhS63+wCjqTi5ADAmAimyMnDmWU7032J6xHwRMrD8CF4dxlV52iIMWjBy1aXE96y
    139NziQDsvFcpSExLW1uOeQPrTzKGjcT/GCwSxY2ubpgI2jPC8EseCp6nTNLN83fB9
    14/rot9gRkyu1Zj5ZYpLSdoJAzJIvTuZtM7vvhwhMJfA7KiGULxQw0x+Scxxg3UIOg
    15P6BI7HPL
    16=5M6D
    17-----END PGP SIGNATURE-----
    

    Timestamp of file with hash 0deb42754ef31a2d35b98c6ac2df5a98f164c3d19f4bd40e6255e095b85c4aec -

28. MarcoFalke referenced this in commit 74c6ad3aab on Dec 9, 2019
29. MarcoFalke merged this on Dec 9, 2019
30. MarcoFalke closed this on Dec 9, 2019

    ---

31. sidhujag referenced this in commit 6ebaa449e9 on Dec 9, 2019
32. jasonbcox referenced this in commit bf4b58bf8c on Nov 6, 2020
33. sidhujag referenced this in commit a600f1456c on Nov 10, 2020
34. practicalswift deleted the branch on Apr 10, 2021
35. random-zebra referenced this in commit 44b5327e61 on May 28, 2021
36. kittywhiskers referenced this in commit 513f867ab5 on Aug 2, 2021
37. kittywhiskers referenced this in commit 1de2abaad5 on Aug 5, 2021
38. kittywhiskers referenced this in commit b1408f5487 on Aug 5, 2021
39. kittywhiskers referenced this in commit 311e98964d on Aug 5, 2021
40. PastaPastaPasta referenced this in commit 29796e428f on Aug 6, 2021
41. kittywhiskers referenced this in commit 31b5b065f5 on Aug 8, 2021
42. kittywhiskers referenced this in commit d2373e53af on Aug 11, 2021
43. 5tefan referenced this in commit 2575b75c0b on Aug 12, 2021
44. DrahtBot locked this on Aug 16, 2022

Contributors
practicalswift DrahtBot MarcoFalke

Labels
Tests