test: Add RegTestingSetup to setup_common #17228

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:1910-RegTestingSetup changing 9 files +56 −33
  1. MarcoFalke commented at 2:59 PM on October 23, 2019: member

    The default chain for TestingSetup is the main chain. However, any test that wants to mine blocks on demand needs to switch to regtest. This is done manually and in-line right now.

    Fix that by creating an explicit RegTestingSetup and use it where appropriate.

    Also, add a move-only commit to move ComputeFilter into the newly created unit test library.

    Both commits are part of #15845, but split up because they are useful on their own.

  2. MarcoFalke added the label Refactoring on Oct 23, 2019
  3. MarcoFalke added the label Tests on Oct 23, 2019
  4. MarcoFalke force-pushed on Oct 23, 2019
  5. DrahtBot commented at 8:27 PM on October 23, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16540 (test: Add ASSERT_DEBUG_LOG to unit test framework by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. practicalswift commented at 10:05 PM on October 27, 2019: contributor

    Concept ACK

  7. test: move-only ComputeFilter to src/test/lib/blockfilter fa54b3e248
  8. test: Add RegTestingSetup to setup_common fa0a731d00
  9. MarcoFalke force-pushed on Oct 30, 2019
  10. MarcoFalke commented at 6:13 PM on October 30, 2019: member

    Rebased

  11. MarcoFalke commented at 8:32 PM on November 1, 2019: member

    Anything left to do here?

  12. practicalswift commented at 12:31 AM on November 2, 2019: contributor

    ACK fa0a731d007a8e76d2740a2e6ead2289de77e475 -- diff looks correct

  13. MarcoFalke referenced this in commit 5933c6d924 on Nov 4, 2019
  14. MarcoFalke merged this on Nov 4, 2019
  15. MarcoFalke closed this on Nov 4, 2019

  16. MarcoFalke deleted the branch on Nov 4, 2019
  17. sidhujag referenced this in commit dda5c932c1 on Nov 7, 2019
  18. deadalnix referenced this in commit 64adf307f1 on Jun 4, 2020
  19. deadalnix referenced this in commit 037cb8a9c0 on Jun 4, 2020
  20. sidhujag referenced this in commit 8cc45f92f2 on Nov 10, 2020
  21. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me