Built on #15921. Please review that first.
Removes the fCheckDuplicateInputs argument from CheckTransaction()
The argument is always set to true, since b8f801964f59586508ea8da6cf3decd76bc0e571.
[WIP] remove fCheckDuplicateInputs from CheckTransaction() #17241
pull jnewbery wants to merge 7 commits into bitcoin:master from jnewbery:2019-10-fduplicateinputs changing 34 files +434 −416-
jnewbery commented at 4:58 PM on October 24, 2019: member
-
de1bffae72
[validation] Add CValidationState subclasses
Split CValidationState into TxValidationState and BlockValidationState to store validation results for transactions and blocks respectively.
-
d6b50c3405
[validation] Tidy Up ValidationResult class
Minor style fixups and comment updates. This is purely a style change. There is no change in behavior.
-
5a6456113b
[validation] Remove error() calls from Invalid() calls
This is in preparation for the next commit, which removes the useless `ret` parameter from ValidationState::Invalid(). error() is simply a convenience wrapper that calls LogPrintf and returns false. Call LogPrintf explicitly and substitute the error() call for a false bool literal.
-
4e64b526dd
[validation] Remove useless ret parameter from Invalid()
ValidationState::Invalid() takes a parameter `ret` which is returned to the caller. All call sites set this to false. Remove the `ret` parameter and just return false always.
-
955dd5f2cf
[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()
No callers use the returned value in first_invalid. Remove it from the function signature and don't set it in the function.
-
9ec6b4fb30
[validation] Remove fMissingInputs from AcceptToMemoryPool()
Handle this failure in the same way as all other failures: call Invalid() with the reasons for the failure.
-
654a9df354
[validation] remove fCheckDuplicateInputs argument from CheckTransaction
This is always set to true, since commit b8f801964f59586508ea8da6cf3decd76bc0e571.
- fanquake added the label Validation on Oct 24, 2019
-
-
- jnewbery closed this on Oct 24, 2019
- DrahtBot locked this on Dec 16, 2021
Labels