refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache #17242

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2019-10-checkinputsfrommempool changing 1 files +4 −3

jnewbery commented at 5:16 PM on October 24, 2019: member

CheckInputsFromMempoolAndCache() is only called in one place, and cacheSigStore is set to true in that call site. Remove the argument entirely.

Also improve commenting.

[validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache

CheckInputsFromMempoolAndCache() is only called in one place, and
cacheSigStore is set to true in that call site. Remove the argument
entirely.

Also improve commenting.

0a433fc876

fanquake added the label Validation on Oct 24, 2019
MarcoFalke added the label Refactoring on Oct 24, 2019
MarcoFalke renamed this:
~~validation: Remove unused cacheSigStore from CheckInputsFromMempooAndCache~~
refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache
on Oct 24, 2019
MarcoFalke commented at 5:34 PM on October 24, 2019: member

unsigned ACK 0a433fc876d82df1005f175c1254fff62f0f36f8 Comment looks good
jamesob commented at 5:37 PM on October 24, 2019: member

ACK https://github.com/bitcoin/bitcoin/pull/17242/commits/0a433fc876d82df1005f175c1254fff62f0f36f8
laanwj commented at 5:53 PM on October 24, 2019: member

Yay, one boolean argument less. ACK 0a433fc876d82df1005f175c1254fff62f0f36f8
DrahtBot commented at 5:57 PM on October 24, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16658 (validation: Rename CheckInputs to CheckInputScripts by jnewbery)
- #15921 (validation: Tidy up ValidationState interface by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake approved
fanquake commented at 12:13 PM on October 25, 2019: member

ACK 0a433fc876d82df1005f175c1254fff62f0f36f8. Checked that CheckInputsFromMempoolAndCache is only called once, in MemPoolAccept::ConsensusScriptChecks, and that cacheSigStore is true.

New comments match CheckInputs params.
fanquake referenced this in commit 48cb468ce3 on Oct 25, 2019
fanquake merged this on Oct 25, 2019
fanquake closed this on Oct 25, 2019
jnewbery deleted the branch on Oct 25, 2019
promag commented at 3:47 PM on October 27, 2019: member

ACK 0a433fc876d82df1005f175c1254fff62f0f36f8.
Fabcien referenced this in commit 9ca4736e58 on Dec 24, 2020
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Refactoring Validation

refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache #17242

Conflicts