GuessVerificationProgress for a header (not a block) is always 0 because the number of txs in the block can not be determined from the header alone. Anyway, this result was never used, so we can optimize this call by hardcoding 0.
This is the next commit in a series of changes toward removing nChainTx (see #14863, #13875)
Anyway, this result was never used
Isn't progress used here even for an header notification https://github.com/bitcoin/bitcoin/blob/be50469217bd775c4305938634c32e5932f47841/src/qt/bitcoingui.cpp#L991
is always 0 because the number of txs in the block can not be determined from the header alone
Right, nChainTx is not known, but I fail to see how it's zero:
https://github.com/bitcoin/bitcoin/blob/be50469217bd775c4305938634c32e5932f47841/src/validation.cpp#L5061-L5076
Right, nChainTx is not known, but I fail to see how it's zero:
It is initialized to zero: https://dev.visucore.com/bitcoin/doxygen/class_c_block_index.html#af3c6d6dd8a7579e5ce516d94b98d2db5 and only set when we have the block downloaded. Without having the transactions downloaded, it is currently impossible to know how many txs there are in the block.
Then GuessVerificationProgress will return zero, because zero divided by something is still zero
It is initialized to zero
Code review ACK fa398091b7ad683dfd3cd3c2cd030eaf9f336737, missed that.
ACK fa398091b7ad683dfd3cd3c2cd030eaf9f336737