nChainTx is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation.
refactor: Add and use HaveTxsDownloaded() where appropriate #14863
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1812-docNchainTx changing 4 files +24 −15-
MarcoFalke commented at 11:19 PM on December 3, 2018: member
- MarcoFalke added the label Refactoring on Dec 3, 2018
- MarcoFalke added the label Docs on Dec 3, 2018
- MarcoFalke force-pushed on Dec 3, 2018
- MarcoFalke force-pushed on Dec 3, 2018
-
promag commented at 11:51 PM on December 3, 2018: member
Concept ACK
Could also update these?: https://github.com/bitcoin/bitcoin/blob/c62b15118997030b007f04618cbca02d7abb1332/src/net_processing.cpp#L569 https://github.com/bitcoin/bitcoin/blob/c62b15118997030b007f04618cbca02d7abb1332/src/net_processing.cpp#L1127 https://github.com/bitcoin/bitcoin/blob/c62b15118997030b007f04618cbca02d7abb1332/src/rpc/blockchain.cpp#L1461
-
Empact commented at 10:29 AM on December 4, 2018: member
Concept ACK
- would make sense as a method on
CBlockIndex - maybe try for privatizing
nChainTxaltogether?
- would make sense as a method on
- MarcoFalke force-pushed on Dec 4, 2018
- MarcoFalke force-pushed on Dec 4, 2018
-
validation: Add and use HaveTxsDownloaded where appropriate fa4fc8856b
- MarcoFalke force-pushed on Dec 4, 2018
-
promag commented at 2:08 PM on December 5, 2018: member
utACK fa4fc88.
-
Empact commented at 7:29 AM on December 7, 2018: member
-
laanwj commented at 1:58 PM on December 7, 2018: member
utACK fa4fc8856b239059421a8e507b3e3e7f4b379a72
- laanwj merged this on Dec 7, 2018
- laanwj closed this on Dec 7, 2018
- laanwj referenced this in commit f544e23556 on Dec 7, 2018
- MarcoFalke deleted the branch on Dec 7, 2018
- laanwj referenced this in commit a25945318f on Oct 28, 2019
- jasonbcox referenced this in commit ba82bd9f92 on Dec 6, 2019
- jonspock referenced this in commit 22a74279bd on Oct 2, 2020
- jonspock referenced this in commit 3f0fbbd6df on Oct 5, 2020
- jonspock referenced this in commit 8305a17a0c on Oct 10, 2020
- Munkybooty referenced this in commit 15492b0ccc on Aug 2, 2021
- Munkybooty referenced this in commit 39cbcc0f94 on Aug 3, 2021
- Munkybooty referenced this in commit 36d4e5bcd8 on Aug 5, 2021
- Munkybooty referenced this in commit b1bcce6fcf on Aug 5, 2021
- Munkybooty referenced this in commit 2537484b08 on Aug 8, 2021
- Munkybooty referenced this in commit f8fcfaad57 on Aug 11, 2021
- Munkybooty referenced this in commit dc26b32019 on Aug 11, 2021
- Munkybooty referenced this in commit c6eeb101f2 on Aug 13, 2021
- Munkybooty referenced this in commit 36efb7ec0d on Aug 15, 2021
- DrahtBot locked this on Sep 8, 2021
