gui: disable font antialiasing for QR image address #17257

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:disable_qr_font_antialiasing changing 1 files +1 −0
  1. fanquake commented at 5:36 PM on October 25, 2019: member

    The address text inside the QR code is currently fairly blurry / unreadable. Explicitly disabling font antialiasing improves that somewhat.

    master (693e40090ae7af52585ce1a6136a4bd56318fac7): macOS_master

    PR (e156b9d8b974f57253306b693a03aa80322ebc6c): macOS_pr

  2. gui: disable font antialiasing for QR image address
    More info available here: https://doc.qt.io/qt-5/qfont.html#StyleStrategy-enum
    e156b9d8b9
  3. fanquake added the label GUI on Oct 25, 2019
  4. luke-jr commented at 5:41 PM on October 25, 2019: member

    That sounds like a platform bug?

    Would rather not disable antialias (an improvement) because of some platforms doing it wrong...

  5. fanquake commented at 5:45 PM on October 25, 2019: member

    Would rather not disable antialias (an improvement) because of some platforms doing it wrong...

    I didn't mention a specific platform in the PR description, because disabling has been an improvement on all the platforms I tested. Can you show me where it's a regression in readability?

  6. MarcoFalke added the label Needs gitian build on Oct 25, 2019
  7. laanwj commented at 9:47 AM on October 26, 2019: member

    ACK e156b9d8b974f57253306b693a03aa80322ebc6c

    Readability takes precedence here over a debatable "improvement" in rendering. On the longer term someone could figure out the cause, and come up with a better patch, but at least this trivial change we can still sneak into 0.19.0.

    67591424-6dd76d80-f72b-11e9-86b6-b3911f8e07e6

    FWIW this looks is a bitmap font, which really don't lend themselves to anti-aliasing, only vector fonts do. (so apparently for bitmap fonts, Qt interprets "anti-aliasing" as doing a smooth scale of the letters instead of a nearest-filter one, i'd say this is a very bad idea)

  8. laanwj added this to the milestone 0.19.0 on Oct 26, 2019
  9. laanwj added the label Needs backport (0.19) on Oct 26, 2019
  10. JeremyCrookshank commented at 10:18 AM on October 26, 2019: contributor

    ACK

  11. DrahtBot commented at 10:29 AM on October 26, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 25d7e2e78137d07eb612c44d19b0d496050c947a (master):

    Gitian builds for commit 7499c796fb447a9de846252a7fa336c684ace90b (master and this pull):

  12. DrahtBot removed the label Needs gitian build on Oct 26, 2019
  13. laanwj referenced this in commit be50469217 on Oct 26, 2019
  14. laanwj merged this on Oct 26, 2019
  15. laanwj closed this on Oct 26, 2019
  16. laanwj removed the label Needs backport (0.19) on Oct 26, 2019
  17. laanwj referenced this in commit eb5a899d5a on Oct 26, 2019
  18. promag commented at 3:43 PM on October 27, 2019: member

    ACK eb5a899d5a973fe5f4700a57da82753f05138460.

  19. fanquake deleted the branch on Oct 28, 2019
  20. HashUnlimited referenced this in commit 31432fc951 on Nov 17, 2019
  21. fxtc referenced this in commit ed83710f65 on Nov 25, 2019
  22. fxtc referenced this in commit dcef0b915e on Nov 25, 2019
  23. hebasto commented at 7:23 AM on September 3, 2020: member

    Reverting suggested in https://github.com/bitcoin-core/gui/pull/71

  24. DrahtBot locked this on Feb 15, 2022
Contributors
fanquakeluke-jrlaanwjJeremyCrookshankDrahtBotpromaghebasto
Labels
GUI

Milestone
0.19.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me