gui: "Increase transaction fee" label should be disabled for watch-only wallets #17263

issue Sjors opened this issue on October 26, 2019

Sjors commented at 9:28 AM on October 26, 2019: member

It's not possible to bump the fee from the GUI in a watch-only wallet, yet the option is enabled:

<img width="344" alt="Schermafbeelding 2019-10-26 om 11 26 47" src="https://user-images.githubusercontent.com/10217/67617446-8e62fe80-f7e3-11e9-80a0-fcc70d683c09.png">

It's also thoroughly confused about the fee, but that's not a problem if we don't show the dialog: <img width="348" alt="Schermafbeelding 2019-10-26 om 11 25 14" src="https://user-images.githubusercontent.com/10217/67617436-6ffd0300-f7e3-11e9-9931-05ab3b705c7f.png">
Sjors added the label Bug on Oct 26, 2019
fanquake added the label GUI on Oct 26, 2019
andronoob commented at 2:27 PM on November 24, 2019: none

I wish this feature will be eventually available for Bitcoin Core.
Sjors commented at 10:41 AM on November 27, 2019: member

Presumably #17492 will fix this (cc @instagibbs).
instagibbs commented at 1:45 PM on November 27, 2019: member

That's actually surprising. It should fail the PreconditionChecks which includes a "can sign" ISMINE check of all inputs?
fanquake commented at 10:22 AM on August 14, 2020: member

@Sjors was this fixed in #17492 (now merged?). If not, can you close and reopen in the GUI repo? Otherwise, this can be closed.
Sjors closed this on Jan 6, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels