Eliminates another linting alert in the linting sequence. In this case it is a false positive. "hist" is used as a variable. https://github.com/bitcoin/bitcoin/blob/6a7c40bee403cadedeecd4b1c6528575522094eb/contrib/seeds/makeseeds.py#L119
build:lint eliminate some lint spelling alerts #17347
pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:makeseeds-py changing 1 files +1 −0-
RandyMcMillan commented at 6:47 PM on November 1, 2019: contributor
-
build:lint add "hist to list of false positives a11377dbdd
- fanquake added the label Tests on Nov 1, 2019
-
RandyMcMillan commented at 6:49 PM on November 1, 2019: contributor
Pretested linting prior to creating PR: https://travis-ci.org/RandyMcMillan/bitcoin/jobs/606139243 https://travis-ci.org/RandyMcMillan/bitcoin/jobs/606139261
-
MarcoFalke commented at 6:58 PM on November 1, 2019: member
What is the point of this? If you want to fix typos, sure. Please go ahead and fix all of them, but this one-off change isn't worth it.
-
fanquake commented at 7:20 PM on November 1, 2019: member
Agree, please try and avoid opening trivial PRs like this.
- fanquake closed this on Nov 1, 2019
-
RandyMcMillan commented at 9:18 PM on November 1, 2019: contributor
It seems that when I lump all these corrections into one PR then it touches too many files. I am happy to submit these either way. I am not trying to submit trivial PRs but the policy seems unclear on this. In this case what is "atomic"? A PR that changes one file? Or one PR that gets the job done? Please advise and I will submit it either way.
Thanks for your guidance on this.
Here are some corrections that I will handle
-
MarcoFalke commented at 9:21 PM on November 1, 2019: member
Yeah all of them can be done in one commit
-
RandyMcMillan commented at 9:22 PM on November 1, 2019: contributor
Yeah all of them can be done in one commit
Thanks for the guidance. I will resubmit using this PR.
- RandyMcMillan renamed this:
build:lint add "hist" to list of false positives
build:lint eliminate some lint spelling alerts
on Nov 2, 2019 -
RandyMcMillan commented at 1:06 AM on November 2, 2019: contributor
@MarcoFalke, Updated to include several lint spelling alerts.
Pretested linting prior to reopening PR: https://travis-ci.org/RandyMcMillan/bitcoin/jobs/606253152 https://travis-ci.org/RandyMcMillan/bitcoin/jobs/606253164
It will have to be reopened to detect the update. https://github.com/RandyMcMillan/bitcoin/commit/ac6d97fc4a1cd04db20fd773a05cd1eb0eebc373
- RandyMcMillan renamed this:
build:lint eliminate some lint spelling alerts
#build:lint eliminate some lint spelling alerts
on Nov 2, 2019 - RandyMcMillan renamed this:
#build:lint eliminate some lint spelling alerts
build:lint eliminate some lint spelling alerts
on Nov 2, 2019 - DrahtBot locked this on Dec 16, 2021
Contributors
Labels