doc: Add ShellCheck to lint tests dependencies #17353

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20191102-lint-dependencies changing 2 files +9 −3
  1. hebasto commented at 3:59 pm on November 2, 2019: member

    In master (9641366950276da88af626d0898676195df8d83a) the lint tests dependencies list lacks ShellCheck. This PR fixes it.

    Also lint-python.sh is slightly improved.

  2. doc: Add ShellCheck to lint tests dependencies 2ad74b78c6
  3. fanquake added the label Tests on Nov 2, 2019
  4. practicalswift commented at 5:37 pm on November 2, 2019: contributor
    ACK 0f7051a02091bd87d2502b8249f5ad977f3a0b84 – diff looks correct
  5. promag commented at 11:07 am on November 6, 2019: member
    ACK 0f7051a02091bd87d2502b8249f5ad977f3a0b84.
  6. in test/lint/lint-python.sh:84 in 0f7051a020 outdated
    88@@ -81,14 +89,6 @@ enabled=(
    89     W606 # 'async' and 'await' are reserved keywords starting with Python 3.7
    90 )
    91 
    92-if ! command -v flake8 > /dev/null; then
    


    laanwj commented at 11:08 am on November 6, 2019:

    Does this cause any problems?

    I think I prefer leaving it here; to have the list of exceptions (a “constant”) above the code as much as possible.


    promag commented at 11:10 am on November 6, 2019:
    Your suggestion LGTM.

    hebasto commented at 11:24 am on November 6, 2019:

    I think I prefer leaving it here; to have the list of exceptions (a “constant”) above the code as much as possible.

    Agree. Fixed.

  7. build: Remove install command samples
    test/README.md contains comprehensive install instructions.
    80c9e66ab8
  8. hebasto force-pushed on Nov 6, 2019
  9. laanwj commented at 11:27 am on November 6, 2019: member

    ACK 80c9e66ab84f8cecc2bf2eebf508a5aad8911246

    Thanks for improving documentation on running these locally. I hope it helps avoid frustrations like #17346.

  10. promag commented at 11:36 am on November 6, 2019: member
    ACK 80c9e66ab84f8cecc2bf2eebf508a5aad8911246, verified internal and external links. Nice looking table.
  11. MarcoFalke referenced this in commit 22a58811d4 on Nov 6, 2019
  12. MarcoFalke merged this on Nov 6, 2019
  13. MarcoFalke closed this on Nov 6, 2019

  14. hebasto deleted the branch on Nov 6, 2019
  15. sidhujag referenced this in commit 70f618835c on Nov 7, 2019
  16. MarkLTZ referenced this in commit 12906a16e9 on Apr 10, 2020
  17. sidhujag referenced this in commit 1cf5d2b313 on Nov 10, 2020
  18. PastaPastaPasta referenced this in commit c9909a46e1 on Sep 11, 2021
  19. PastaPastaPasta referenced this in commit 249156f604 on Sep 11, 2021
  20. PastaPastaPasta referenced this in commit ae1b698535 on Sep 12, 2021
  21. PastaPastaPasta referenced this in commit e07e1fbb2a on Sep 12, 2021
  22. PastaPastaPasta referenced this in commit 51cb517ba6 on Sep 12, 2021
  23. PastaPastaPasta referenced this in commit 176c4b4ddf on Sep 14, 2021
  24. PastaPastaPasta referenced this in commit a2fcb09150 on Sep 14, 2021
  25. PastaPastaPasta referenced this in commit 13a57764e2 on Sep 15, 2021
  26. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me