cli: fix -getinfo output when compiled with no wallet #17368

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fix_getinfo_no_wallet changing 1 files +1 −1

fanquake commented at 7:46 PM on November 4, 2019: member

master (33b155f28732487854cf0ca29ca17c50f8c6872e):

src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 602348,
  "headers": 602348,
  "verificationprogress": 0.9999995592310106,
  "timeoffset": 0,
  "connections": 10,
  "proxy": "",
  "difficulty": 13691480038694.45,
  "chain": "main",
  "walletversion": null,
  "balance": null,
  "keypoololdest": null,
  "keypoolsize": null,
  "paytxfee": null,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

This PR (3d05d332693ec860626fc77e6ba50dec94e4e83c):

{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 602348,
  "headers": 602348,
  "verificationprogress": 0.9999996313568186,
  "timeoffset": 0,
  "connections": 10,
  "proxy": "",
  "difficulty": 13691480038694.45,
  "chain": "main",
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

cli: fix -getinfo output when compiled with no wallet 3d05d33269
fanquake added the label Utils/log/libs on Nov 4, 2019
MarcoFalke commented at 7:56 PM on November 4, 2019: member

ouch ACK 3d05d332693ec860626fc77e6ba50dec94e4e83c
darosior approved
darosior commented at 8:57 PM on November 4, 2019: member

ACK 3d05d332693ec860626fc77e6ba50dec94e4e83c
laanwj commented at 9:40 AM on November 6, 2019: member

ACK 3d05d332693ec860626fc77e6ba50dec94e4e83c

When did this break? (E.g. does this need backport?)
laanwj referenced this in commit 7967104aee on Nov 6, 2019
laanwj merged this on Nov 6, 2019
laanwj closed this on Nov 6, 2019
fanquake deleted the branch on Nov 6, 2019
sidhujag referenced this in commit 2626d74482 on Nov 7, 2019
fanquake referenced this in commit 2d0b3c0716 on Nov 8, 2019
fanquake commented at 2:15 PM on November 8, 2019: member

When did this break? (E.g. does this need backport?)

Looks like it. Backported in #17417.
laanwj referenced this in commit c7c8e3e072 on Nov 10, 2019
laanwj referenced this in commit 890dc0a7cc on Nov 14, 2019
HashUnlimited referenced this in commit bbf202134f on Nov 17, 2019
fxtc referenced this in commit 6c65e72d1b on Nov 25, 2019
fxtc referenced this in commit 31556e9abc on Nov 25, 2019
fxtc referenced this in commit 105da5ab73 on Nov 25, 2019
fxtc referenced this in commit 7f5aa10721 on Nov 25, 2019
deadalnix referenced this in commit dffe4818c3 on Nov 4, 2020
sidhujag referenced this in commit 912c0491df on Nov 10, 2020
PastaPastaPasta referenced this in commit 72b339c953 on Oct 20, 2021
pravblockc referenced this in commit 5e536aa92c on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17417 [0.19] cli: fix -getinfo output when compiled with no wallet