rpc: Remove unused boost::this_thread::interruption_point #17382

There are predefined interruption points for boost::thread: https://www.boost.org/doc/libs/1_71_0/doc/html/thread/thread_management.html#interruption_points

However, the rpc threads are std::thread, which does not have an std::thread::interrupt member function to request interruption: https://dev.visucore.com/bitcoin/doxygen/httpserver_8cpp.html#ae1a63374e18b9abd348eb74e4243ea34

Thus, the interruption points can be removed.

ACK fa5facd3e72b6d61374b0b93b722b55e2b090020, this does nothing.

If the goal is to be interruptible, add checks for IsRPCRunning() instead (assuming RPC code).

ACK fa5facd3e72b6d61374b0b93b722b55e2b090020

Good catch!

ACK https://github.com/bitcoin/bitcoin/pull/17382/commits/fa5facd3e72b6d61374b0b93b722b55e2b090020

I wouldn't be sure about the ones in validation and indexing (the script check threads are part of a thread group, after all), but aren't these untriggerable as well?

src/wallet/db.cpp:    boost::this_thread::interruption_point();
src/wallet/db.cpp:    boost::this_thread::interruption_point();
src/wallet/db.cpp:            boost::this_thread::interruption_point();

Edit: oh, maybe not, at least BerkeleyBatch::PeriodicFlush(BerkeleyDatabase& database) could be called from a scheduler thread. The interruption point on open / construction is weirder.