wallet: Remove unused boost::this_thread::interruption_point #17405

1. 
   MarcoFalke commented at 9:03 pm on November 7, 2019: member

   BerkeleyEnvironment::Open is only called from the main thread (init) or an http rpc thread, neither of which can be interrupted, so remove the useless interruption point.

   BerkeleyEnvironment{} is only used in tests, which run in a single process/thread, so remove the useless interruption point.

2. wallet: Remove unused boost::this_thread::interruption_point fad1de66a2
3. MarcoFalke added the label Refactoring on Nov 7, 2019
4. MarcoFalke force-pushed on Nov 7, 2019
5. MarcoFalke added the label Wallet on Nov 7, 2019
6. 
   laanwj commented at 11:49 pm on November 7, 2019: member

   Also, interruption points are supposed to be called in loops for long operations, not one at the beginning of constructors. This was very strange.

   ACK fad1de66a29bf6bd348a932150dad7d472feb3d0

7. 
   DrahtBot commented at 12:38 pm on November 8, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17410 (Rename db log category to walletdb (like coindb) by laanwj)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. fanquake approved
9. 
   fanquake commented at 1:54 pm on November 8, 2019: member

   ACK fad1de66a29bf6bd348a932150dad7d472feb3d0
10. fanquake referenced this in commit 8021392b82 on Nov 8, 2019
11. fanquake merged this on Nov 8, 2019
12. fanquake closed this on Nov 8, 2019

    ---

13. MarcoFalke deleted the branch on Nov 8, 2019
14. sidhujag referenced this in commit 36a012eb22 on Nov 9, 2019
15. MarkLTZ referenced this in commit b171112df1 on Nov 29, 2019
16. jasonbcox referenced this in commit e51055fa30 on Oct 1, 2020
17. sidhujag referenced this in commit 0f9fde4a51 on Nov 10, 2020
18. UdjinM6 referenced this in commit 5c5f9b5fb6 on Jul 15, 2021
19. UdjinM6 referenced this in commit 7de223cd2e on Jul 15, 2021
20. UdjinM6 referenced this in commit 1722e83588 on Jul 15, 2021
21. kittywhiskers referenced this in commit f20f872592 on Jul 16, 2021
22. UdjinM6 referenced this in commit 730a89f8ed on Jul 16, 2021
23. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke laanwj DrahtBot fanquake

Labels
Refactoring Wallet