Rename `db` log category to `walletdb` (like `coindb`) #17410

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2019_11_rename_db_log_category changing 5 files +26 −13

laanwj commented at 7:29 AM on November 8, 2019: member

Rename the db log category to walletdb (in the style of, and to distinguish from coindb). Deprecate (but still accept) '-debug=db'.

Second commit is a scripted commit that changes the enum item name.
laanwj added the label Utils/log/libs on Nov 8, 2019
laanwj force-pushed on Nov 8, 2019
practicalswift commented at 9:43 AM on November 8, 2019: contributor

ACK 97330653b49c4b7d5e7646a28dc14906a574a005 -- diff looks correct and disambiguation is good
DrahtBot commented at 12:37 PM on November 8, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16688 (log: Add validation interface logging by jkczyz)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke added the label Needs release note on Nov 8, 2019
MarcoFalke commented at 1:45 PM on November 8, 2019: member

ACK 97330653b49c4b7d5e7646a28dc14906a574a005

needs release notes
DrahtBot added the label Needs rebase on Nov 8, 2019
DrahtBot commented at 3:11 PM on November 8, 2019: member

Needs rebase
Rename `db` log category to `walletdb` (like `coindb`)
Deprecate (but still accept) '-debug=db'.
6b42b3ba90

scripted-diff: Change `BCLog::DB` to `BCLog::WALLETDB`

-BEGIN VERIFY SCRIPT-
git grep -l "BCLog::DB" src | xargs sed -i "s/BCLog::DB/BCLog::WALLETDB/g"
sed -i "s/DB          =/WALLETDB    =/g" src/logging.h
-END VERIFY SCRIPT-

4c1d263d93

laanwj force-pushed on Nov 8, 2019
laanwj removed the label Needs rebase on Nov 8, 2019
laanwj removed the label Needs release note on Nov 8, 2019
laanwj commented at 5:53 PM on November 8, 2019: member

Rebased and added release note.

in doc/release-notes-17410.md:4 in 1a0007218f outdated

   0 | @@ -0,0 +1,4 @@
   1 | +Command-line options
   2 | +--------------------
   3 | +
   4 | +- The `-debug=db` logging category has been renamed to `-debug=walletdb`, to distinguish it from `coindb`.

MarcoFalke commented at 6:16 PM on November 8, 2019:

- The `-debug=db` logging category has been renamed to `-debug=walletdb`, to distinguish it from `coindb`.
  `-debug=db` has been deprecated and will be removed in the next major release.

laanwj commented at 6:20 PM on November 8, 2019:

Thanks, will add that. Was trying to keep it succinct, this is not worth making the release notes much longer over. But that's good to mention.

jonasschnelli commented at 9:37 PM on November 8, 2019: contributor

utACK 1a0007218f15f85e2c7952bbdb4a84ec2351bfe2
doc: Add relase note for db→walletdb rename e2c03c1156
laanwj force-pushed on Nov 8, 2019
hebasto approved

hebasto commented at 12:24 PM on November 9, 2019: member

ACK e2c03c1156a1a8cb2c04c180f2ddbd3535126a46, tested on Linux Mint 19.2:

$ ./src/bitcoind -debug=db
...
2019-11-09T12:21:25Z [init] Warning: logging category 'db' is deprecated, use 'walletdb' instead
...

$ ./src/bitcoin-cli logging | grep true
  "walletdb": true,

laanwj referenced this in commit cef7df37ce on Nov 10, 2019
laanwj merged this on Nov 10, 2019
laanwj closed this on Nov 10, 2019
sidhujag referenced this in commit bb1cb75908 on Nov 10, 2019
jonatack referenced this in commit e16b2dd9e6 on Nov 10, 2019
MarkLTZ referenced this in commit d8f26f3f44 on Nov 29, 2019
MarcoFalke referenced this in commit b3091b2be7 on Jun 7, 2020
jasonbcox referenced this in commit d8bb96b2fd on Oct 1, 2020
sidhujag referenced this in commit c25ce4821c on Nov 10, 2020
PastaPastaPasta referenced this in commit 3cc72a3911 on Jun 27, 2021
PastaPastaPasta referenced this in commit 82cfd1f2c6 on Jun 28, 2021
PastaPastaPasta referenced this in commit 580db11a48 on Jun 29, 2021
PastaPastaPasta referenced this in commit 7bb572c513 on Jul 1, 2021
PastaPastaPasta referenced this in commit d4a34f9b4a on Jul 1, 2021
PastaPastaPasta referenced this in commit d33d4ef240 on Sep 14, 2021
PastaPastaPasta referenced this in commit fbec52bacd on Sep 14, 2021
PastaPastaPasta referenced this in commit 9ca2c0a8a6 on Sep 15, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#19202 log: remove deprecated `db` log category

Rename `db` log category to `walletdb` (like `coindb`) #17410

Conflicts