Separate alert key for testnet #1744

1. 
   gavinandresen commented at 9:11 PM on August 28, 2012: contributor

   Two commits; the first just refactors most of the alert-handling code into alert.cpp/alert.h

   The second gives testnet its own alert key, which is the right thing to do because if it shares the main network's key somebody could take testnet test alerts and rebroadcast them on the main network.

2. Refactor: move alert code from main to alert.cpp/h f35c6c4fb9
3. Give testnet it's own alert key. 286dbba2d2
4. 
   laanwj commented at 6:41 PM on August 29, 2012: member

   ACK for 0.8

5. 
   jgarzik commented at 4:00 PM on September 4, 2012: contributor

   Why not ACK for 0.7?

6. 
   laanwj commented at 4:31 PM on September 4, 2012: member

   Because it's a huge change between two rcs.

7. 
   jgarzik commented at 4:35 PM on September 4, 2012: contributor

   Seems like a two-one-liners change to me, which will eliminate the rebroadcast problem.

   Zero-change refactors during -rc do not seem like a big deal.

8. 
   gmaxwell commented at 4:43 PM on September 4, 2012: contributor

   I'd somewhat prefer to pull this in 0.7; but being that its an alert I'm not able to test beyond just starting up a node with it. ACK in any case.

9. 
   gavinandresen commented at 5:03 PM on September 4, 2012: contributor

   I'll send the testnet alert key to all the core devs.

   And will go with consensus on pulling / not pulling for 0.7rc2.

10. 
    laanwj commented at 5:06 PM on September 4, 2012: member

    Ok @jgarzik I hadn't done a line-by-line comparison yet. If it's just code movement, apart from the added key, it's fine for me to merge it into rc2.

11. 
    jgarzik commented at 3:43 AM on September 5, 2012: contributor

    ACK for 0.7, here

12. 
    Diapolo commented at 3:41 PM on September 5, 2012: none

    Seems like a good thing for 0.7 IMO.

13. gavinandresen merged this on Sep 5, 2012
14. gavinandresen closed this on Sep 5, 2012

    ---

15. 
    BitcoinPullTester commented at 10:33 PM on September 5, 2012: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/286dbba2d238f523b45f5649345ae89b64cbba2f for binaries and test log.

16. DrahtBot locked this on Sep 8, 2021

Milestone
0.7.0