"merkleRoot" #17442"> "merkleRoot" #17442"> fix Typo: "merkelRoot" -> "merkleRoot" #17442

fix Typo: "merkelRoot" -> "merkleRoot" #17442

pull ianliuy wants to merge 1 commits into bitcoin:master from ianliuy:master changing 1 files +2 −2
  1. ianliuy commented at 4:58 PM on November 11, 2019: contributor

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. fix Typo: "merkelRoot" -> "merkleRoot" eb880f092b
  3. DrahtBot added the label Tests on Nov 11, 2019
  4. practicalswift commented at 6:14 PM on November 11, 2019: contributor

    ACK eb880f092b4154cf66fe96fc42ffdeff309e3975 but please change from merkleRootofHashes to merkleRootOfHashes

    Welcome as a contributor! Good contributor careers typically start with a small typo fix! :)

  5. MarcoFalke commented at 6:21 PM on November 11, 2019: member

    merkleRootOfHashes

    We use snake_case, but I think this is good to go.

  6. MarcoFalke referenced this in commit 80fdb6fad1 on Nov 11, 2019
  7. MarcoFalke merged this on Nov 11, 2019
  8. MarcoFalke closed this on Nov 11, 2019

  9. MarkLTZ referenced this in commit 5f93072eb1 on Nov 17, 2019
  10. PastaPastaPasta referenced this in commit 5a8377a9e1 on Jun 27, 2021
  11. PastaPastaPasta referenced this in commit 98c30ee94e on Jun 28, 2021
  12. PastaPastaPasta referenced this in commit ba7145e354 on Jun 29, 2021
  13. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me