wallet: Avoid showing GUI popups on RPC errors (take 2) #17444

1. 
   MarcoFalke commented at 6:52 pm on November 11, 2019: member

   Commit 8b0d82bb428de9e7f1da7c61574e7a8376a62d43 claims “This commit does not change behavior.” However, it re-introduced the bug I tried to fix in #17070
2. wallet: Avoid showing GUI popups on RPC errors (take 2) faffa7f0dc
3. MarcoFalke added the label Wallet on Nov 11, 2019
4. ryanofsky approved
5. 
   ryanofsky commented at 7:16 pm on November 11, 2019: member

   Code review ACK faffa7f0dcc9971cb20534816eccdf75bebc853a

   The new call to initError added in 8b0d82bb428de9e7f1da7c61574e7a8376a62d43 should have been caught in #17304 review, but that was a pretty big PR, so not that surprising it was missed.

   The actual bug probably came from a bad rebase, since the change creating LegacyScriptPubKeyMan::Upgrade was written before #17070.

   This is also making me think if there’s a way to rearrange things so that initError isn’t available to code that shouldn’t be calling it. Maybe making it a method of an init interface rather than the chain interface.

6. 
   DrahtBot commented at 7:37 pm on November 11, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17261 (Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101)
   • #16224 (gui: Bilingual GUI error messages by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. MarcoFalke referenced this in commit b7bc9b8330 on Nov 20, 2019
8. MarcoFalke merged this on Nov 20, 2019
9. MarcoFalke closed this on Nov 20, 2019

   ---

10. MarcoFalke deleted the branch on Nov 20, 2019
11. sidhujag referenced this in commit 32cde68f0b on Nov 21, 2019
12. jasonbcox referenced this in commit a93566bb87 on Sep 30, 2020
13. sidhujag referenced this in commit e45b937895 on Nov 10, 2020
14. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke ryanofsky DrahtBot

Labels
Wallet