gui: Changed tooltip for 'Label' & 'Message' text fields to be more clear #17446

pull dannmat wants to merge 1 commits into bitcoin:master from dannmat:Nov-19-Remove-Message-Input changing 1 files +2 −2
  1. dannmat commented at 10:34 PM on November 11, 2019: none

    I have changed the tooltips for 'Label' & 'Message' text fields to be more clear, stating the difference between the two (#17173)

  2. fanquake added the label GUI on Nov 11, 2019
  3. DrahtBot added the label Needs rebase on Nov 11, 2019
  4. laanwj commented at 9:24 AM on November 12, 2019: member

    Message is part of the original BIP21, not BIP70, so NACK on removing it from the parser functions.

    It's intended to be shown by wallets upon scanning the QR code, or getting the URI. I'm fairly sure some light wallets do.

    If people are not using this functionality it's an OK idea to remove from the GUI, explain it better or make it hidden by default. But before removing it from the GUI we'd need to know for sure whether maybe PoS applications are using it.

  5. dannmat commented at 9:30 AM on November 12, 2019: none

    I don't understand the difference between the label and message though?

  6. laanwj commented at 9:39 AM on November 12, 2019: member

    As I understand it, the label is meant to be relatively short and is stored in the wallet (so anything identifying the invoice should be there), the message can add some extra information for the customer, and may or may not be stored.

  7. dannmat commented at 10:15 AM on November 12, 2019: none

    Ahh I see. So what are we doing now? Keep the text field but explain it better? I feel like "label" and "message" could be worded better to show their intentions, for example "wallet reference" instead of label and "invoice message" instead of message or something.

  8. laanwj commented at 10:23 AM on November 12, 2019: member

    'label' is used all over the place in the wallet, there's no chance to change this term, as for message, I don't know. Changing terminology is hard, especially if it's part of a BIP. It's going to be controversial at the least. But at least it's less commonly used than label.

    An easier documentation-only approach would be to add/change tooltips, and maybe add better placeholder text.

  9. MarcoFalke commented at 1:40 PM on November 12, 2019: member

    Oh, I wasn't aware that both of them end up in the qr code/the URI. Sorry for giving false hints. I agree that better tooltips would help me understand it.

    • It should probably mention that label is used in the wallet to label the transaction and is also part of the BIP21 URI.
    • The message is only part of the BIP21 URI?
  10. dannmat commented at 4:59 PM on November 12, 2019: none

    Ok I'll revert this commit tonight and add a tooltip

  11. dannmat force-pushed on Nov 12, 2019
  12. dannmat commented at 10:08 PM on November 12, 2019: none

    I have reverted the commit, added placeholders (open to criticism on the content). Squashed and rebased.

  13. DrahtBot removed the label Needs rebase on Nov 12, 2019
  14. fanquake commented at 3:26 PM on November 15, 2019: member

    @dannmat You need to update the PR title and description.

  15. fanquake added the label Waiting for author on Nov 15, 2019
  16. dannmat renamed this:
    Removed 'Message' text field + references from receive area
    Changed tooltip for 'Label' & 'Message' text fields to be more clear
    on Nov 15, 2019
  17. dannmat commented at 3:33 PM on November 15, 2019: none

    @fanquake I've updated the title. What do you mean by description?

  18. in src/qt/forms/receivecoinsdialog.ui:96 in 3fd444aea2 outdated 
      92 | @@ -93,7 +93,7 @@
  93 |          <item row="6" column="2">
  94 |           <widget class="QLineEdit" name="reqMessage">
  95 |            <property name="toolTip">
  96 | -           <string>An optional message to attach to the payment request, which will be displayed when the request is opened. Note: The message will not be sent with the payment over the Bitcoin network.</string>
  97 | +           <string>An optional message that may be displayed to the sender.</string>
    MarcoFalke commented at 3:36 PM on November 15, 2019: 
               <string>An optional message that is attached to the payment request and may be displayed to the sender.</string>
  19. fanquake commented at 3:37 PM on November 15, 2019: member

    I have removed the Message text field (as referenced in #17173) @dannmat The PR text and the screenshot no longer reflect the current change.

  20. in src/qt/forms/receivecoinsdialog.ui:66 in 3fd444aea2 outdated 
      62 | @@ -63,7 +63,7 @@
  63 |          <item row="4" column="2">
  64 |           <widget class="QLineEdit" name="reqLabel">
  65 |            <property name="toolTip">
  66 | -           <string>An optional label to associate with the new receiving address.</string>
  67 | +           <string>An optional label to associate with the new receiving address (used by you to identify an invoice).</string>
    MarcoFalke commented at 3:37 PM on November 15, 2019: 
               <string>An optional label to associate with the new receiving address (used by you to identify an invoice). It is also attached to the payment request.</string>
  21. MarcoFalke commented at 3:38 PM on November 15, 2019: member

    Could clarify that even the label is attached to the payment request. (Which doesn't make any sense to me because the label is something that should be private to your own wallet)

  22. Changed tooltips of receive form to highlight difference between Label and Message 8944c1d340
  23. dannmat force-pushed on Nov 17, 2019
  24. dannmat commented at 12:01 PM on November 17, 2019: none

    I've updated these changes and committed/squashed & rebased

  25. MarcoFalke renamed this:
    Changed tooltip for 'Label' & 'Message' text fields to be more clear
    gui: Changed tooltip for 'Label' & 'Message' text fields to be more clear
    on Nov 17, 2019
  26. MarcoFalke removed the label Waiting for author on Nov 17, 2019
  27. MarcoFalke commented at 2:23 PM on November 17, 2019: member

    ACK 8944c1d340ac2be45b505ada7e187b770b0b036f

  28. dannmat commented at 1:05 PM on November 20, 2019: none

    Updated the description

  29. laanwj commented at 1:22 PM on November 20, 2019: member

    ACK 8944c1d340ac2be45b505ada7e187b770b0b036f

  30. laanwj referenced this in commit 26744ae189 on Nov 20, 2019
  31. laanwj merged this on Nov 20, 2019
  32. laanwj closed this on Nov 20, 2019
  33. sidhujag referenced this in commit bc5edceb24 on Nov 20, 2019
  34. MarkLTZ referenced this in commit b191f8f518 on Nov 29, 2019
  35. deadalnix referenced this in commit 69356afdad on Nov 5, 2020
  36. sidhujag referenced this in commit e4d89715b5 on Nov 10, 2020
  37. MarcoFalke locked this on Dec 16, 2021
Contributors
dannmatlaanwjMarcoFalkefanquake
Labels
GUI
Linked (view graph)
#17173 gui: Explain what "message" means in the receive tab
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me