This change updates the Info.plist that is bundled with the macOS app.
It removes references to bitcoinfoundation.org It updates the copyright years -- section 2205.1(F) It capitalizes "Developers" -- section 2204.1
This PR is related to #17311 sections -- 2207.1(E), 2207.2, 2207.9, 2206.1
REF: https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf
old
new
This change updates the Info.plist that is bundled with the macOS app.
It removes references to bitcoinfoundation.org
It updates the copyright years - section 2205.1(F)
It capitalizes "Developers" - section 2204.1
This PR is related to #17311
sections - 2207.1(E), 2207.2, 2207.9, 2206.1
REF: https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf
37 | @@ -38,15 +38,15 @@ 38 | <true/> 39 | 40 | <key>CFBundleIdentifier</key> 41 | - <string>org.bitcoinfoundation.Bitcoin-Qt</string> 42 | + <string>org.bitcoincore.Bitcoin-Qt</string>
I think this could have further consequences... though not sure.
This change is dangerous. It will wipe out the settings https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleidentifier
Yes - there are "consequences" to the changes proposed in this PR. The long term benefits IMO out weigh the short term transition with the goals of this PR. More explanations soon.
NACK, as this will wipe all user settings.
We could append the major-minor-client release to the app name. Example “Bitcoin Core-0.2.0.app”
This would preserve the existing installed app but allow for upgrades moving forward.
16 | @@ -17,10 +17,10 @@ 17 | <string>APPL</string> 18 | 19 | <key>CFBundleGetInfoString</key> 20 | - <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string> 21 | + <string>Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string> 22 | 23 | <key>CFBundleShortVersionString</key> 24 | - <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@</string>
That is the SHORT version string. This should be used for major releases (in this case we should include the minor release number but the client number is for the regular version string.
I will update the PR and add better explanations soon.
One of the goals in this PR will result in better issue tracking for the macOS builds.
320 | @@ -321,4 +321,3 @@ clean-local: clean-docs 321 | rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP) 322 | rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__ 323 | rm -rf osx_volname dist/ dpi36.background.tiff dpi72.background.tiff 324 | -
Please don't make unrelated changes in PRs.
We could append the major-minor-client release to the app name. Example “Bitcoin Core-0.2.0.app”
NACK. Also NACK the CFBundleIdentifier identifier changes.
6 | @@ -7,7 +7,7 @@ define(_CLIENT_VERSION_BUILD, 0) 7 | define(_CLIENT_VERSION_RC, 0) 8 | define(_CLIENT_VERSION_IS_RELEASE, false) 9 | define(_COPYRIGHT_YEAR, 2019) 10 | -define(_COPYRIGHT_HOLDERS,[The %s developers]) 11 | +define(_COPYRIGHT_HOLDERS,[The %s Developers])
Please don't change this.
Edit: oh, this change is the point of the PR. Ok, in that case: this is up for discussion.
Sorry, you really shouldn't do a buck-shot of changes and call it a "fix". I assumed there was some bugfix buried.
16 | @@ -17,10 +17,10 @@ 17 | <string>APPL</string> 18 | 19 | <key>CFBundleGetInfoString</key> 20 | - <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
Removing the version from here will mean it doesn't show up in the Version portion of the app info. I don't think that's what we want to do.
