build: macOS fix Info.plist #17462

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:info-plist changing 3 files +7 −8
  1. RandyMcMillan commented at 4:21 AM on November 13, 2019: contributor

    This change updates the Info.plist that is bundled with the macOS app.

    It removes references to bitcoinfoundation.org It updates the copyright years -- section 2205.1(F) It capitalizes "Developers" -- section 2204.1

    This PR is related to #17311 sections -- 2207.1(E), 2207.2, 2207.9, 2206.1

    REF: https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf

    old Screen Shot 2019-11-12 at 9 49 28 PM new Screen Shot 2019-11-12 at 9 49 08 PM

  2. DrahtBot added the label Build system on Nov 13, 2019
  3. fanquake added the label macOS on Nov 13, 2019
  4. fix Info.plist
    This change updates the Info.plist that is bundled with the macOS app.
    
    It removes references to bitcoinfoundation.org
    It updates the copyright years - section 2205.1(F)
    It capitalizes "Developers" - section 2204.1
    
    This PR is related to #17311
    sections - 2207.1(E), 2207.2, 2207.9, 2206.1
    REF: https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf
    2065864020
  5. in share/qt/Info.plist.in:41 in 2065864020
      37 | @@ -38,15 +38,15 @@
      38 |    <true/>
      39 |  
      40 |    <key>CFBundleIdentifier</key>
      41 | -  <string>org.bitcoinfoundation.Bitcoin-Qt</string>
      42 | +  <string>org.bitcoincore.Bitcoin-Qt</string>
    


    jonasschnelli commented at 8:00 AM on November 13, 2019:

    I think this could have further consequences... though not sure.

    • codesigning?
    • internal paths for preferences/settings?

    emilengler commented at 10:24 AM on November 13, 2019:

    RandyMcMillan commented at 10:15 PM on November 14, 2019:

    Yes - there are "consequences" to the changes proposed in this PR. The long term benefits IMO out weigh the short term transition with the goals of this PR. More explanations soon.

  6. MarcoFalke commented at 1:38 PM on November 13, 2019: member

    NACK, as this will wipe all user settings.

  7. RandyMcMillan commented at 5:14 PM on November 13, 2019: contributor

    We could append the major-minor-client release to the app name. Example “Bitcoin Core-0.2.0.app”

    This would preserve the existing installed app but allow for upgrades moving forward.

  8. in share/qt/Info.plist.in:23 in 2065864020
      16 | @@ -17,10 +17,10 @@
      17 |    <string>APPL</string>
      18 |  
      19 |    <key>CFBundleGetInfoString</key>
      20 | -  <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
      21 | +  <string>Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
      22 |  
      23 |    <key>CFBundleShortVersionString</key>
      24 | -  <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@</string>
    


    fanquake commented at 6:11 PM on November 14, 2019:

    Why are you removing @CLIENT_VERSION_REVISION?


    RandyMcMillan commented at 9:43 PM on November 14, 2019:

    That is the SHORT version string. This should be used for major releases (in this case we should include the minor release number but the client number is for the regular version string.

    I will update the PR and add better explanations soon.


    RandyMcMillan commented at 9:56 PM on November 14, 2019:

    One of the goals in this PR will result in better issue tracking for the macOS builds.


    fanquake commented at 1:49 PM on November 15, 2019:

    That is the SHORT version string.

    I'd rather use the full version string, to avoid any ambiguity. Shortened version strings have caused issues in the past. See #4029 and #14697.

  9. in Makefile.am:324 in 2065864020
     320 | @@ -321,4 +321,3 @@ clean-local: clean-docs
     321 |  	rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP)
     322 |  	rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__
     323 |  	rm -rf osx_volname dist/ dpi36.background.tiff dpi72.background.tiff
     324 | -
    


    fanquake commented at 6:11 PM on November 14, 2019:

    Please don't make unrelated changes in PRs.

  10. fanquake commented at 6:21 PM on November 14, 2019: member

    We could append the major-minor-client release to the app name. Example “Bitcoin Core-0.2.0.app”

    NACK. Also NACK the CFBundleIdentifier identifier changes.

  11. in configure.ac:10 in 2065864020
       6 | @@ -7,7 +7,7 @@ define(_CLIENT_VERSION_BUILD, 0)
       7 |  define(_CLIENT_VERSION_RC, 0)
       8 |  define(_CLIENT_VERSION_IS_RELEASE, false)
       9 |  define(_COPYRIGHT_YEAR, 2019)
      10 | -define(_COPYRIGHT_HOLDERS,[The %s developers])
      11 | +define(_COPYRIGHT_HOLDERS,[The %s Developers])
    


    laanwj commented at 11:39 AM on November 15, 2019:

    Please don't change this. Edit: oh, this change is the point of the PR. Ok, in that case: this is up for discussion. Sorry, you really shouldn't do a buck-shot of changes and call it a "fix". I assumed there was some bugfix buried.

  12. in share/qt/Info.plist.in:20 in 2065864020
      16 | @@ -17,10 +17,10 @@
      17 |    <string>APPL</string>
      18 |  
      19 |    <key>CFBundleGetInfoString</key>
      20 | -  <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
    


    fanquake commented at 1:51 PM on November 15, 2019:

    Removing the version from here will mean it doesn't show up in the Version portion of the app info. I don't think that's what we want to do. versions

  13. fanquake added the label Waiting for author on Nov 19, 2019
  14. RandyMcMillan closed this on Nov 19, 2019

  15. fanquake removed the label Waiting for author on May 28, 2020
  16. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me