test: skip tests when utils haven't been compiled #17497

1. 
   fanquake commented at 2:01 AM on November 17, 2019: member

   Don't try and run the interface_bitcoin_cli.py test when bitcoin-cli isn't available.

   stdout:
   2019-11-17T01:51:41.623000Z TestFramework (INFO): Initializing test directory /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/test_runner_₿_🏃_20191116_205141/interface_bitcoin_cli_0
   2019-11-17T01:51:41.890000Z TestFramework (ERROR): Unexpected exception caught during testing
   Traceback (most recent call last):
     File "/Users/michael/github/bitcoin/test/functional/test_framework/test_framework.py", line 111, in main
       self.run_test()
     File "/Users/michael/github/bitcoin/test/functional/interface_bitcoin_cli.py", line 18, in run_test
       cli_response = self.nodes[0].cli("-version").send_cli()
     File "/Users/michael/github/bitcoin/test/functional/test_framework/test_node.py", line 528, in send_cli
       process = subprocess.Popen(p_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
     File "/Users/michael/.pyenv/versions/3.5.6/lib/python3.5/subprocess.py", line 676, in __init__
       restore_signals, start_new_session)
     File "/Users/michael/.pyenv/versions/3.5.6/lib/python3.5/subprocess.py", line 1289, in _execute_child
       raise child_exception_type(errno_num, err_msg)
   FileNotFoundError: [Errno 2] No such file or directory: '/Users/michael/github/bitcoin/src/bitcoin-cli'
   

2. fanquake added the label Tests on Nov 17, 2019
3. 
   laanwj commented at 12:25 PM on November 18, 2019: member

   ACK daf0da4dba46fa797d4368a1e403604b59903ae7

4. fanquake added the label Waiting for author on Nov 18, 2019
5. 
   fanquake commented at 9:13 PM on November 18, 2019: member

   There are some additional related failures I'm going to push fixes for.

6. test: skip bitcoin_cli test when the cli isn't compiled 621d398750
7. test: skip wallet_listreceivedby test when the cli isn't compiled e9277baed6
8. test: skip tool_wallet test when bitcoin-wallet isn't compiled a67352161c
9. fanquake force-pushed on Nov 18, 2019
10. fanquake removed the label Waiting for author on Nov 18, 2019
11. 
    fanquake commented at 9:53 PM on November 18, 2019: member

    Added commits to skip wallet_listreceivedby.py when there's no bitcoin-cli and tool_wallet.py when there's no bitcoin-wallet. i.e ./configure --with-utils=no.

12. fanquake requested review from MarcoFalke on Nov 18, 2019
13. fanquake renamed this:
    test: skip interface_bitcoin_cli when the cli isn't compiled
    test: skip tests when utils haven't been compiled
    on Nov 18, 2019
14. MarcoFalke referenced this in commit e1df922132 on Nov 19, 2019
15. MarcoFalke merged this on Nov 19, 2019
16. MarcoFalke closed this on Nov 19, 2019

    ---

17. fanquake deleted the branch on Nov 19, 2019
18. sidhujag referenced this in commit 836c0d8480 on Nov 19, 2019
19. deadalnix referenced this in commit e895e15b9a on Apr 22, 2020
20. sidhujag referenced this in commit 7cda2750f7 on Nov 10, 2020
21. DrahtBot locked this on Dec 16, 2021

Contributors

fanquakelaanwj

Review Requested
MarcoFalke