Simpler settings interpretation #17508

issue ryanofsky opened this issue on November 18, 2019

ryanofsky commented at 4:23 PM on November 18, 2019: contributor

Settings code cleanup in #15934 uncovered some surprising ways settings are being interpreted.

Most or all of unexpected behaviors should be possible to simplify in some followup changes, and this issue tracks the followups:

| Bug | Fix | Notes | - | - | - | | Ignored network-qualified arguments | #17482 | Release notes (Command line) Ignored chain arguments | tbd Reversed config precedence | #17581 | Release notes (Configuration file). PR depends on #17493 to disallow multiple config assignments, which depends #17556 to fix a fragile python test and #17580 to apply ALLOW_LIST flags, which depends on #16545 to implement ALLOW_LIST flags Misapplied default section config values | tbd Zombie config values | tbd
laanwj added the label Utils/log/libs on Nov 19, 2019
laanwj referenced this in commit 8a56f79d49 on Feb 5, 2020
sidhujag referenced this in commit ac84b589c1 on Feb 9, 2020
sidhujag referenced this in commit 9166566ec7 on Nov 10, 2020
Munkybooty referenced this in commit 8810028e5c on Sep 23, 2022
Munkybooty referenced this in commit 468f220802 on Oct 3, 2022
Munkybooty referenced this in commit 81e5bb6153 on Oct 13, 2022
Munkybooty referenced this in commit 145c836b0c on Oct 13, 2022
PastaPastaPasta referenced this in commit 54f74ba539 on Oct 16, 2022
willcl-ark removed the label Utils/log/libs on Oct 16, 2025
willcl-ark added the label Settings on Oct 16, 2025
willcl-ark commented at 3:02 PM on October 21, 2025: member

Closing this as it hasn’t seen any activity for a while. If you’d like to continue the discussion or feel the topic is still important, please leave a comment and we can reopen it.
willcl-ark closed this on Oct 21, 2025

Contributors

ryanofsky

willcl-ark

Labels

Settings

Linked (view graph)

#15934 Merge settings one place instead of five places #16545 refactor: Implement missing error checking for ArgsManager flags #17482 util: Disallow network-qualified command line options #17493 util: Forbid ambiguous multiple assignments in config file #17556 test: Change feature_config_args.py not to rely on strange regtest=0 behavior #17580 refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags #17581 refactor: Remove settings merge reverse precedence code